update rgbds 1.0.3

[SelvinPL]

apply fixes for build:

• createSymbol(intern(name))
• ZLIB::ZLIB and PNG::PNG
• temporarily override execute_process for passing rgbds version correctly

[SelvinPL]

instead hacking execute_process it would be nice if rgbds would not use git for obtaining version if fx there is some CMAKE var already

[SelvinPL]

the problem is that current build takes version from tag ... but ... with our build ${CMAKE_SOURCE_DIR}
points to rgbds-live not rgbds ...
this change forces cmake to land in this path https://github.com/gbdev/rgbds/blob/v1.0.3/CMakeLists.txt#L100C5-L100C96

[ISSOtm]

It seems simpler to modify it to be CMAKE_CURRENT_SOURCE_DIR?

[SelvinPL]

1. i belive i tried it
2. there will be "-dirty" problem still

[SelvinPL]

yeap

-- Determining RGBDS version from Git history
-- Determining RGBDS version from Git history - 9d3bf94-dirty
CMake Warning at rgbds/CMakeLists.txt:109 (message):
  No `v*` Git tag reachable; falling back

# # no git for you rgbds
# # this hack will stop rgbds build from obtain rgbds-live version from git
# # it will be passed via BUILD_VERSION_STRING
# macro(execute_process)
#     if("${ARGV}" MATCHES "describe")
#         set(result 1)
#     else()
#         _execute_process(${ARGV})
#     endif()
# endmacro()

set(CMAKE_CURRENT_SOURCE_DIR_BCKUP ${CMAKE_CURRENT_SOURCE_DIR})

set(CMAKE_CURRENT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/rgbds)

# and we will put em into this target
add_custom_target(rgbds)

# importing rgbds
add_subdirectory(rgbds EXCLUDE_FROM_ALL)

# restore execute_process
macro(execute_process)
    _execute_process(${ARGV})
endmacro()

# target specific configuration for rgbds
foreach(TGT ${RGBDS_TARGETS})
    if(TARGET ${TGT})
        set_target_properties(${TGT} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${RGBDS_LIVE_OUT_DIR}")
        if("${TGT}" STREQUAL "rgbasm")
            set(EXP_NAME "createRgbAsm")
        elseif("${TGT}" STREQUAL "rgblink")
            set(EXP_NAME "createRgbLink")
        elseif("${TGT}" STREQUAL "rgbfix")
            set(EXP_NAME "createRgbFix")
        endif()
        target_compile_definitions(${TGT} PRIVATE BUILD_VERSION_STRING="${RGBDS_VERSION_FROM_GIT}")
        target_link_options(${TGT} PRIVATE 
            "-sEXPORT_NAME=${EXP_NAME}"
            "-sEXPORTED_RUNTIME_METHODS=['FS']"
            )
        add_dependencies(rgbds ${TGT})
    endif()
endforeach()
add_dependencies(rgbds_live rgbds)

set(CMAKE_CURRENT_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR_BCKUP})

still not working

[SelvinPL]

i've tried with

set(CMAKE_CURRENT_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/rgbds" CACHE PATH "" FORCE)

also with CMAKE_SOURCE_DIR ... it doesn't work

[SelvinPL]

... it would be so much easier with gbdev/rgbds#1604

[SelvinPL]

set(CMAKE_DISABLE_FIND_PACKAGE_Git ON)
add_subdirectory(rgbds EXCLUDE_FROM_ALL)
unset(CMAKE_DISABLE_FIND_PACKAGE_Git)

less hacky

[SelvinPL]

... but only if we do no use

find_program(RGBDS_LIVE_GIT NAMES git)
if(RGBDS_LIVE_GIT)

instead

find_package(Git REQUIRED)

[ISSOtm]

1.0.3 incorporates gbdev/rgbds@d5033a2bd, which does use find_package(Git). Either way, RGBDS needs a few build system fixes/improvements.

[SelvinPL]

I'm not sure were are we going here ...

• adding patch is bad idea ... you change the cmake script and patch will stop working (that's why we are here - not build script but changes in source and patch incompatibility)
• i've provied solution and i've tested "modify it to be CMAKE_CURRENT_SOURCE_DIR" - it is not working

[SelvinPL]

only caveat with latest solution is when we start tagging this repo with "vXXXX"
it will fail

-- Determining RGBDS version from Git history - v1.0.3-4-g3831883-dirty
CMake Error at rgbds/CMakeLists.txt:111 (message):
  Version mismatch! Git says v1.0.3,

            version.hpp says v!

[SelvinPL]

for summary, I see 3 solutions:

1. currently proposed

# setting version in common target sets it globaly
if(TARGET common)
    target_compile_definitions(common PRIVATE "BUILD_VERSION_STRING=\"${RGBDS_VERSION_FROM_GIT}\"")
    target_compile_options(common PRIVATE -Wno-macro-redefined)
endif()

• pros: we are not hacking find_package behavior
• cons: if we start tagging with "vXXX" this repo, there will be conflict

2. disable ability to acces git in rgbds

• pros: we are depending on fallback (as per @Rangi42 comment - but only if git access is disabled in other case we hit this), so in fact we could get rid of checking rgbds version with git at all
• cons: it's hacky way ... so we need to switch from find_package to find_program in out script for accessing git (like applying patch)

3. patching rgbd's cmake script

• pros: i don't see any
• cons: it will kick our bottoms every time rgbd's cmake script will be changed (well, it's exaggeration - only if patched part would be changed - i just hate when my "perfect" build script fails )