Skip to content

Interface to change password - #49

Open
SophiaJefferson wants to merge 2 commits into
milestone_2from
change_password1
Open

Interface to change password#49
SophiaJefferson wants to merge 2 commits into
milestone_2from
change_password1

Conversation

@SophiaJefferson

@SophiaJefferson SophiaJefferson commented Apr 13, 2018

Copy link
Copy Markdown
Collaborator

Hopefully I created changepassword.jsp correctly. Let me know if you have any corrections or tips on it. It looks like you already edited the User object to make the password editable so that is not included in this pull request -- if you have any tips or suggestions, feel free to leave them here & let me know

@SophiaJefferson
SophiaJefferson requested a review from jeoratz April 13, 2018 22:39
@jeoratz

jeoratz commented Apr 27, 2018

Copy link
Copy Markdown
Collaborator

Is there a servlet that goes along with this? Also the profile stuff is done so you can pull the profile branch to add the linking if you want :) also just a note for the servlet when that happens - it will need to hash the password before sending it to setPassword() since it's not hashed there (and I'm also pretty sure there will need to be changes to the writeThrough method so that the new password persists.

@SophiaJefferson

Copy link
Copy Markdown
Collaborator Author

Thanks for letting me know Jenna! I also just added servlet mappings because I orginally forgot. Yes, I was going to add that servlet to issue #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants