Repository navigation
Use the return value of CloseMutableBasis instead of IsContainedInSpan - #12
Merged
Merged
Conversation
CloseMutableBasis returns whether it enlarged the basis, so calling IsContainedInSpan first does the same elimination twice. The return value is available in GAP 4.12, the oldest version SLA supports. See gap-system/gap#6288 Assisted-by: Claude Code (Opus 5.5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 97.14% 97.15%
=======================================
Files 16 16
Lines 92590 92584 -6
=======================================
- Hits 89951 89950 -1
+ Misses 2639 2634 -5
🚀 New features to boost your workflow:
|
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloseMutableBasisreturns whether it enlarged the basis, so callingIsContainedInSpanright before it does the same elimination twice. This replaces the six such pairs in SLA, as suggested in gap-system/gap#6288 and done for the GAP library in gap-system/gap#6287.AI disclosure: Claude Code (Opus 5.5) made the change, ran the checks above and wrote this description.