Move samples to catalog where appropriate, create discussions for other ideas#811
Merged
edwardchalstrey1 merged 8 commits intomasterfrom Mar 19, 2026
Merged
Move samples to catalog where appropriate, create discussions for other ideas#811edwardchalstrey1 merged 8 commits intomasterfrom
edwardchalstrey1 merged 8 commits intomasterfrom
Conversation
…sues raised (as appropriate) for further action in curating all of the examples from those sources
Merged
* initial test refactor * deduplicate game slugs * Update error handling in test_catalog_load_all_game_slugs * load 2smp game from contrib instead of catalog * Update Makefile.am * fix reiley game * correct ext
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
edwardchalstrey1
approved these changes
Mar 19, 2026
Member
edwardchalstrey1
left a comment
edwardchalstrey1
left a comment
There was a problem hiding this comment.
Looks good to me - @tturocy I had to change the reiley2008 game as the payoffs weren't correct, but that actually led me down a useful test-improvement rabbit hole, this PR now improves the catalog tests and will error if you try to add a game to the catalog that can't be loaded by read_efg or read_nfg
Member
|
Also @tturocy - do you think it's worth me updating the "stripped down poker" tutorial to after constructing the game from code say "this is the same as the catalog game 'reiley2008/fig1'"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates some of the standalone "samples" from the old docs into the catalog where appropriate, adding citation details and descriptions.
Other "samples" are examples from a paper where there are other interesting things that should be done alongside (capturing other examples, possibly doing a tutorial/example notebook). These have been noted as ideas for discussion.
A few others are lower priority so we don't do anything with them at the moment. For example the
nimgame actually doesn't even really map onto the Van Huyck experiment. And theloopbackexample for QRE should be part of a larger set of examples (and this parameterisation isn't even the best one for illustrating what's going on).