Open
Conversation
…ender as well as introduced typescript type definitions.
|
Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included here:
Expose the deviceIdentifier as provided by Bugfender, used to uniquely identify an instance out in the field.
Changed the location of the bugfender framework, as
node_modulesis usually not committed to a build repository, it prevents a commit to be valid across multiple computers. To solve this, the location of the bugfender.framework should be changed from./node_modules/react-native-bugfenderto./ios/frameworksIncluded typescript type definitions making the library useful to those doing development with a strongly typed language. This type definition also works as documentation of the code.
Updated the readme file to give it a bit more structure and include the same for the
deviceIdentifier()method.