Open
Conversation
Author
|
Builds were failing due to an issue with |
Author
|
This is passing on Node versions > 4 on Travis, but seems to be failing on AppVeyor Node version 5. 🤷♂️ |
Author
|
Both of the failures are not related to the content of this PR: Seems like a AppVeyor infrastructure specific thing. Anyway, this has become an issue again for us, and has previously caused us to delay moving to the latest LTS Node, so we've temporarily published Anyone up the chain ready to look at this PR? |
|
this fixed my problem! thanks! |
|
This would solve compilation problems with Node v13. Any chance the PR could be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #24.
Closes #24.