fix: correct deno opentelemetry exporter examples - #3905
Open
dvd233 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localhost:4318)OTEL_TRACES_EXPORTER=consoleexample with Deno's built-inOTEL_EXPORTER_OTLP_PROTOCOL=consolesetting4317, and add a service name to the examplesWhy
Fresh's OpenTelemetry page currently uses an exporter variable from other OpenTelemetry SDKs. Deno's built-in integration ignores that setting, so the advertised console command produces no telemetry. The page also sends the default HTTP/protobuf exporter to port
4317, which is the OTLP gRPC port; Deno's default HTTP/protobuf endpoint islocalhost:4318.The examples now match Deno's documented environment-variable names, protocol selection, and defaults. The Jaeger image line is intentionally left untouched because the separate open PR #3849 already updates that line; this change can merge cleanly with that work.
Tests
OTEL_TRACES_EXPORTER=consoleemitted 0 spans/metrics;OTEL_EXPORTER_OTLP_PROTOCOL=consoleemitted 2 spans and 4 metrics/v1/tracesand/v1/metricsrequests tolocalhost:4318; overriding only the endpoint to port4317still sent HTTP/protobuf, confirming the documented port/protocol mismatchdeno task check:docsdeno fmt --check docs/latest/advanced/opentelemetry.mddeno task build-wwwgit diff --checkRepository-wide
deno task okreaches the existing formatter gate but reports two pre-existing generated CSS formatting differences inwww/static/prism.cssandwww/static/docsearch.css; neither file is changed by this PR.Fixes #3834