Skip to content

Fix: correct site name correctly in backup and drop multiple site jobs#280

Merged
revant merged 9 commits into
frappe:mainfrom
Improwised:fix/jobs
May 27, 2026
Merged

Fix: correct site name correctly in backup and drop multiple site jobs#280
revant merged 9 commits into
frappe:mainfrom
Improwised:fix/jobs

Conversation

@disha-itpl
Copy link
Copy Markdown
Contributor

Summary

This PR fixes an issue in the backup-multiple-sites and drop-multiple-sites Helm job templates where the full site map was being passed to the --site flag instead of the actual site name.

Problem

The jobs iterate over:

sites:
  - name: "frappe.helpdesk.local"

However, the template previously used:

--site={{ $site }}

Since $site is a map (e.g., map[name:frappe.helpdesk.local]), the generated command became invalid:

bench --site=map[name:frappe.helpdesk.local] backup

This caused the jobs to fail.

Fix

Updated the templates to correctly reference:

--site={{ $site.name }}

This ensures the generated command is:

bench --site=frappe.helpdesk.local backup

The same correction has been applied to both:

  • backup-multiple-sites
  • drop-multiple-sites

Validation

  • Deployed the updated chart.
  • Verified that backup and drop jobs now execute successfully.
  • Confirmed correct --site argument in generated pod logs.

@revant revant merged commit a517a24 into frappe:main May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants