Merged
Conversation
github-actions
bot
added
the
Auto submit to Marketplace on merge
madebyisaacr
commented
Apr 3, 2026
| disabled={!isAllowedToManage} | ||
| title={isAllowedToManage ? undefined : "Insufficient permissions"} | ||
| className="whitespace-nowrap inline-block" | ||
| className={cx("whitespace-nowrap", !isPending && "inline-block")} |
Collaborator
Author
There was a problem hiding this comment.
This is a fix for the loading spinner being left aligned instead of centered. Not related to the other changes in this PR.
kaloyanvi
reviewed
Apr 7, 2026
|
|
||
| const uniqueHeaderRowNames = generateUniqueNames(headerRow) | ||
| const enrichedFields = enrichFieldsWithEnumCases(fields, uniqueHeaderRowNames, rows) | ||
| const needsFieldSchemaUpdate = !configureFields || enrichedFields.some(field => field.type === "enum") |
Collaborator
There was a problem hiding this comment.
configureFields is always false since we never pass it, so this const always evaluates to true.
kaloyanvi
reviewed
Apr 7, 2026
Collaborator
There was a problem hiding this comment.
do we need to pass configureFields: true in the onSubmit handler on L235?
kaloyanvi
reviewed
Apr 7, 2026
kaloyanvi
reviewed
Apr 7, 2026
Collaborator
kaloyanvi
left a comment
kaloyanvi
left a comment
There was a problem hiding this comment.
Left a few comments, as a whole it looks good if we fix those 💪🏻
Collaborator
Author
|
@kaloyanvi I fixed |
madebyisaacr
had a problem deploying
to
production
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the option field type to Google Sheets.
Originally I was working on finishing #608 but after fixing the bugs, the code was too complex and the logic was hard to follow. So I started over from scratch with a simpler solution.
Notes:
Slack thread: https://framer-team.slack.com/archives/C06L5H5ADK2/p1774388000311629
Changelog
Testing
Testing sheet - I used the status column as an option field: https://docs.google.com/spreadsheets/d/1qfTkbZqlAzmGmW3SpaYASdu8qWKmKFrxGCvO8YIdblo/edit?gid=0#gid=0