Skip to content

fix(webui): address Fable UX merge review findings - #76

Merged
tachyon-beep merged 2 commits into
mainfrom
codex/web-ux-fable-fixes
Oct 10, 2026
Merged

tachyon-beep merged 2 commits into
mainfrom
codex/web-ux-fable-fixes

Conversation

@tachyon-beep

@tachyon-beep tachyon-beep commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Pausing and resuming the latest match feed could silently retain the current match ID, leaving the viewer on a replay when the next match started. Resume now restores latest-feed intent; explicit match links retain their identity. This follows up merged UX PR #75 and Filigree keisei-c6be36286d.

  • Keep an out-of-range paused position stable across live appends.
  • Reuse populated live-game history when pausing, avoiding redundant archive downloads.
  • Announce malformed showcase links once and accurately expose matchup disclosure state; retain useful focus when live data empties.
  • Record the Claude Code fable --effort high review, five confirmed findings and repairs, and the SQLite timeout false positive (both actual readers report 5000 ms).

Validation: 463 frontend tests, production build, Ruff and mypy (68 files) pass. Real Chromium checks cover all five resume controls, actual WebSocket append and match rollover, explicit archive identity, error recovery, disclosure behavior and phone reflow. Claude Code Fable high accepted the repair re-review, then separately accepted the final focus follow-up with no actionable findings (sessions a3487536-0b73-422d-8610-537d6cbf3339 and 23c940a4-78f7-4c06-8ab4-021093356527). A real live-data empty transition also verifies useful focus retention; the refreshed original 14-check browser flow passes. All seven final-head hosted CI jobs passed in run 38009897545 at ab7a699f7599d1ab4c093cc914bc2b579819cbeb. Actual screen-reader acceptance remains Unable to test, as accepted by the user, under keisei-ebe3c4bef2.

Screenshots: paused clamp, filtered desktop, filtered phone. Full review and executable browser evidence are in docs/reviews/web-ux-remediation/fable-review.md.

@tachyon-beep
tachyon-beep marked this pull request as ready for review October 10, 2026 00:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-10T00:41:19.199584Z ab7a699 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tachyon-beep
tachyon-beep merged commit 02d2559 into main Oct 10, 2026
7 checks passed
@tachyon-beep
tachyon-beep deleted the codex/web-ux-fable-fixes branch October 10, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant