Skip to content

fix: remove 'data' from _REMOVE_FILE_COMMAND_RESULT #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjk7119 merged 1 commit into from
Apr 15, 2026
+2 −3
Merged

fix: remove 'data' from _REMOVE_FILE_COMMAND_RESULT #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/fosslight_binary/binary_analysis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
logger = logging.getLogger(constant.LOGGER_NAME)

_REMOVE_FILE_EXTENSION = ['json', 'js']
_REMOVE_FILE_COMMAND_RESULT = [
'data', 'timezone data', 'apple binary property list']
_REMOVE_FILE_COMMAND_RESULT = ['timezone data', 'apple binary property list']
Comment thread
coderabbitai[bot] marked this conversation as resolved.
INCLUDE_FILE_COMMAND_RESULT = ['current ar archive']

_error_logs = []
Expand Down Expand Up @@ -320,7 +319,7 @@ def check_binary(file_with_path, skip_remove_file_command_result: bool = False):
"""
:param file_with_path: Path to the file to classify.
:param skip_remove_file_command_result: If True, do not treat
_REMOVE_FILE_COMMAND_RESULT magic prefixes (e.g. 'data') as non-binary.
_REMOVE_FILE_COMMAND_RESULT magic prefixes as non-binary.
"""
is_bin_confirmed = False
file = os.path.basename(file_with_path)
Expand Down
Loading