Skip to content

added 'read up to here' button on entries in articleList, moved open utton to top of toolbar (was to close to readuptohere)#1086

Open
otdftr wants to merge 4 commits into
fossar:masterfrom
otdftr:os_extensions
Open

added 'read up to here' button on entries in articleList, moved open utton to top of toolbar (was to close to readuptohere)#1086
otdftr wants to merge 4 commits into
fossar:masterfrom
otdftr:os_extensions

Conversation

@otdftr

@otdftr otdftr commented Feb 3, 2019

Copy link
Copy Markdown

a feature I found very useful in NEWSIFY: mark read "up to here"
hacked into my v2.18 installation of Selfoss and wanted to share it as a suggested feature

@niol

niol commented Feb 4, 2019

Copy link
Copy Markdown
Collaborator

This is a good idea. This may be an answer to #1021 .
As for the code, I would suggest not including history comments in the source and less code duplication (creating selfoss.dbOnline.mark(ids) and selfoss.ui.mark(ids) may help though handling the possible rollback may be tricky). Hopefully I can fix that later if this get accepted.

@otdftr

otdftr commented Feb 4, 2019 via email

Copy link
Copy Markdown
Author

@jtojnar

jtojnar commented Jul 13, 2020

Copy link
Copy Markdown
Member

Sorry, forgot to reply here.

I like this idea and occasionally wanted this myself but I wanted to avoid cluttering the interface with more buttons so until we come up with a way to let users customize the buttons (perhaps extend the share config to other buttons as well) I would suggest users to add the snippet to their user.js file and am concerned about the code duplication.

I think selfoss.dbOnline.mark(ids) would be very useful since the markVisibleRead is already beyond tolerable complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants