@W-22203675 fix: generate session-meta.json when starting agent preview session#199
Merged
Merged
Conversation
Contributor
|
Got this from claude: Code Quality sessionManager.ts
|
|
|
||
| // Write session-meta.json so SF CLI and other consumers can discover this session | ||
| const sessionType = agentSource === AgentSource.SCRIPT ? (isLiveMode ? 'live' : 'simulated') : 'published'; | ||
| await createPreviewSessionCache(this.state.agentInstance, { |
Contributor
There was a problem hiding this comment.
in endSession, should we delete this session-meta.json as well?
Contributor
Author
There was a problem hiding this comment.
When you end a session using the "sf agent preview end" command, it is no longer listed when running "sf agent preview sessions"; however, all the files are retained. I believe that if the command deletes the other files, it should also delete this one.
Contributor
There was a problem hiding this comment.
right, the CLI command does delete this. But if you stop the session from VS code, should that delete the session as well?
franciscoperezsammartino
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-22203675@
What does this PR do?
What issues does this PR fix or reference?
#, @@
Functionality Before
<insert gif and/or summary>
Functionality After
<insert gif and/or summary>
Testing Setup Notes