Fix check_allocation_size / memory_pool_collection#198
Open
jodyhagins wants to merge 2 commits intofoonathan:mainfrom
Open
Fix check_allocation_size / memory_pool_collection#198jodyhagins wants to merge 2 commits intofoonathan:mainfrom
jodyhagins wants to merge 2 commits intofoonathan:mainfrom
Conversation
added 2 commits
August 28, 2025 22:39
The allocation functions in the specialization of allocator_traits
for memory_pool_collection check for overaligned allocations.
The comment says...
bad_allocation_size exception if \c size / \c alignment exceeds
\ref max_no de_size() / the suitable alignment value
but the code does something very different (not sure really).
I think the intent is to make sure a properly aligned size for the
allocation will fit within the buffer size, so this change applies
that reasoning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allocation functions in the specialization of allocator_traits for memory_pool_collection check for overaligned allocations.
The comment says...
but the code does something very different (not sure really).
I think the intent is to make sure a properly aligned size for the allocation will fit within the buffer size, so this change applies that reasoning.