fix(explorer): preserve trailing slash for Windows drive root#2829
Open
RaphCoder13 wants to merge 2 commits intofolke:mainfrom
Open
fix(explorer): preserve trailing slash for Windows drive root#2829RaphCoder13 wants to merge 2 commits intofolke:mainfrom
RaphCoder13 wants to merge 2 commits intofolke:mainfrom
Conversation
5683513 to
547a8df
Compare
Needed to allow folder opening from drive root in windows
547a8df to
b391196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
On Windows, navigating to a drive root (e.g.,
C:\) insnacks.explorerdisplays incorrect content. Instead of listing the actual root directory, the explorer falls back to the current working directory.Root Cause
The local
norm(path)function inlua/snacks/explorer/tree.luaunconditionally strips trailing slashes:On Windows, C: and C:\ (or C:/) are not semantically equivalent:
Stripping the slash forces Neovim/libuv to interpret C: as a relative drive path, which breaks root navigation
Steps to Reproduce
Proposed Fix
Preserve the trailing slash for Windows drive roots by adding a platform-aware check
Cross-Platform Safety
Testing
Verified on Windows 11 and Windows 10 / Neovim 0.16.4. Drive root navigation now works correctly on first open, without requiring manual cd workarounds or cache pre-warming.