Repository navigation
Conversation
The "Automatic export" checkbox was calculated account-first, which predates integrations without account numbers. Mirror the rule of mod-data-export-worker instead: a non-default integration with an empty account list matches all of the vendor's lines, and the default integration excludes only accounts listed on other integrations. Match ordering integrations only. Claiming integrations share the vendorEdiOrdersExportConfig shape and were matched as well, so a claiming config could toggle the checkbox and narrow the default ordering integration. Expose getApplicableOrderingIntegrations so the UI can show which integrations apply.
The checkbox only tells the orderer that a line is flagged for export, not which integration picks it up. Add a read-only hint next to the checkbox in the edit form and the detail view: the integration name with its transmission method for a single match, an info popover listing the candidates for several matches, and a warning icon when no integration matches while the checkbox is on. The detail view fetches the integration configs only when the hint can show something and hides it while they load, so the warning does not flash before the data arrives. Manual orders are never exported, so the hint is hidden for them and the checkbox is no longer auto-toggled. The detail view now carries the same explanatory popover as the edit form.
|
thomas-sc
marked this pull request as ready for review
October 21, 2026 05:53
thomas-sc
requested review from
Dmytro-Melnyshyn,
NikitaSedyx,
SerhiiNosko,
alisher-epam and
usavkov-epam
October 21, 2026 05:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
On a PO line the "Automatic export" checkbox only tells the orderer that the line is flagged for export, not which integration will pick it up, and nothing shows when no integration matches at all. Add a read-only hint next to the checkbox, in the edit form and in the detail view, and align the checkbox calculation with the backend routing.
Approach
getApplicableOrderingIntegrationsreproduces the PO line query that mod-data-export-worker builds for each integration (MapToEdifactOrdersTasklet#getPoLineQueryand#getVendorAccountFilteron master, MODEXPW-628). An integration applies to a line when the acquisition method is in itsdefaultAcquisitionMethodsand the account filter matches:accountNoList, or every line of the vendor when the list is emptytoggleAutomaticExportsets the checkbox to whether any integration applies. For EDI integrations with account numbers the result is the same as before. The one difference follows the backend: a line whose account is on no list is now flagged for export when the vendor has a default integration.Only
EDIFACT_ORDERS_EXPORTconfigs take part. Claiming configs store their settings in the samevendorEdiOrdersExportConfigstructure, and the current lookup on master searches all configs of the vendor by account number without checking the type. So a claiming config with a matching account number decides the checkbox today, by its own acquisition methods.The hint renders one of three states: the name of the single matching integration with its transmission method below the checkbox, an info popover listing several matches, or a warning icon when nothing matches while the checkbox is on. Several matches are not an error in the backend: the first scheduled job sets
lastEDIExportDateand the others skip the line, so the popover says so. The hint is hidden while the checkbox is off, for manual orders (never exported, see UIOR-890), while the configs load, and in order templates, which pass no configs. The detail view fetches the configs only when the hint can show something.Deliberately not part of the hint:
lastEDIExportDateand the workflow status. The hint says which integration applies to the line, not whether the next run will take it.Screenshots
show matching integration
no matching integration
multiple matching integrations
Refs UIOR-1556
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.