Skip to content

[material_ui] Migrate AppBar M3 template to use new gen_defaults script#12122

Open
QuncCccccc wants to merge 3 commits into
flutter:m3e_migrationfrom
QuncCccccc:app_bar_m3_defaults_migration
Open

[material_ui] Migrate AppBar M3 template to use new gen_defaults script#12122
QuncCccccc wants to merge 3 commits into
flutter:m3e_migrationfrom
QuncCccccc:app_bar_m3_defaults_migration

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Fixes flutter/flutter#188397

Initially gen_defaults script and its templates were used to handle JSON tokens. After we fix the token pipeline and make it possible to get M3E tokens, we use Dart constants and re-created the gen_defaults in material_ui. After decoupling, the old gen_defaults will be deprecated soon.

This PR is to:

  • create a template for M3 AppBar so we can use new script to generate M3 defaults.
  • move the generated code to generated/ folder so all M3 and M3E generated code will be in the same location.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 6, 2026
@QuncCccccc QuncCccccc changed the title Migrate AppBar M3 template to use new gen_defaults script [material_ui] Migrate AppBar M3 template to use new gen_defaults script Jul 6, 2026
@QuncCccccc QuncCccccc force-pushed the app_bar_m3_defaults_migration branch from 0d0154f to 8f8747b Compare July 14, 2026 20:36
@QuncCccccc QuncCccccc requested a review from elliette July 14, 2026 23:22
@QuncCccccc QuncCccccc marked this pull request as ready for review July 14, 2026 23:22

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts the generated Material 3 AppBar defaults into a separate file, app_bar_m3_defaults.g.dart, and introduces an AppBarTemplate class to generate this file automatically. A unit test has also been added to verify the generated defaults. Feedback suggests removing an obsolete // ignore: unused_local_variable comment in gen_defaults.dart since the verbose variable is now utilized.

Comment thread packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant