Add initial PR review skills and skill validation hooks. - #9930
Add initial PR review skills and skill validation hooks.#9930kenzieschmoll wants to merge 5 commits into
Conversation
|
CC @pq since this is related to some of the things you are looking at. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new markdown files defining workflows for reviewing pull requests: a general PR review workflow (reviewing-prs/SKILL.md) and a DevTools-specific PR review workflow (reviewing-devtools-prs/SKILL.md). The review feedback points out that the relative paths to the style guide, repository constraints, and code style files in the DevTools-specific workflow are incorrect and should be adjusted to reflect the file's directory depth.
| - **Style Guide**: [styleguide.md](../../.gemini/styleguide.md) (severity tags `[MUST-FIX]`, `[CONCERN]`, `[NIT]`, zero-formatting policy, copyright headers, DRY rules, named constants) | ||
| - **Repository Constraints**: [AGENTS.md](../../AGENTS.md) | ||
| - **Code Style**: [STYLE.md](../../STYLE.md) |
There was a problem hiding this comment.
[CONCERN] The relative paths to the style guide, repository constraints, and code style files are incorrect. Since this file is located at .agents/skills/reviewing-devtools-prs/SKILL.md, it is 3 levels deep from the repository root. Therefore, the paths should use ../../../ instead of ../../ to correctly reference these files at the root level.
| - **Style Guide**: [styleguide.md](../../.gemini/styleguide.md) (severity tags `[MUST-FIX]`, `[CONCERN]`, `[NIT]`, zero-formatting policy, copyright headers, DRY rules, named constants) | |
| - **Repository Constraints**: [AGENTS.md](../../AGENTS.md) | |
| - **Code Style**: [STYLE.md](../../STYLE.md) | |
| - **Style Guide**: [styleguide.md](../../../.gemini/styleguide.md) (severity tags [MUST-FIX], [CONCERN], [NIT], zero-formatting policy, copyright headers, DRY rules, named constants) | |
| - **Repository Constraints**: [AGENTS.md](../../../AGENTS.md) | |
| - **Code Style**: [STYLE.md](../../../STYLE.md) |
References
- Prefix every comment with a severity: [MUST-FIX], [CONCERN], [NIT]. (link)
There was a problem hiding this comment.
@reidbaker shouldn't dart skills lint catch this?
kenzieschmoll
changed the title
2 participants
This PR adds two agent skills to the devtools repo:
reviewing-prs: General workflow for fetching, inspecting, reviewing GitHub Pull Requests using the gh CLI, drafting user-aligned review comments, and securing approval before posting. Use when asked to review a GitHub PR or pull request.reviewing-devtools-prs: DevTools repository-specific PR review workflow enforcing DevTools style guidelines and repository rules. Use when reviewing pull requests in the flutter/devtools repository.These skills should be iterated on over time but they do provide initial value in their current state to help locally reviewing PRs with agents.
This PR also adds two hooks to the devtools repo: