Skip to content

[listen] Makes error context non-null#30

Open
chunhtai wants to merge 1 commit into
flutter:mainfrom
chunhtai:more-update
Open

[listen] Makes error context non-null#30
chunhtai wants to merge 1 commit into
flutter:mainfrom
chunhtai:more-update

Conversation

@chunhtai

Copy link
Copy Markdown
Contributor

as title

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: listen labels Jul 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ErrorCallback signature in the listen package, changing the ErrorContext parameter from an optional named parameter to a required positional parameter. All internal usages and tests are updated to match this new signature, and the package version is bumped to 1.0.0-beta.4. Feedback suggests updating the changelog entry to explicitly mention that ErrorContext is now a required positional parameter to clarify the breaking change.

@@ -1,3 +1,7 @@
## 1.0.0-beta.4

- `ErrorContext` is now a non-nullable parameter.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog mentions that ErrorContext is now non-nullable, but it does not mention that it has been changed from an optional named parameter ({ErrorContext? context}) to a required positional parameter (ErrorContext context). Since this is a breaking change that requires updating call sites (removing the context: label), it would be highly beneficial to document this explicitly in the changelog.

Suggested change
- `ErrorContext` is now a non-nullable parameter.
- `ErrorContext` is now a required positional, non-nullable parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: listen triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant