[listen] Makes error context non-null#30
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the ErrorCallback signature in the listen package, changing the ErrorContext parameter from an optional named parameter to a required positional parameter. All internal usages and tests are updated to match this new signature, and the package version is bumped to 1.0.0-beta.4. Feedback suggests updating the changelog entry to explicitly mention that ErrorContext is now a required positional parameter to clarify the breaking change.
| @@ -1,3 +1,7 @@ | |||
| ## 1.0.0-beta.4 | |||
|
|
|||
| - `ErrorContext` is now a non-nullable parameter. | |||
There was a problem hiding this comment.
The changelog mentions that ErrorContext is now non-nullable, but it does not mention that it has been changed from an optional named parameter ({ErrorContext? context}) to a required positional parameter (ErrorContext context). Since this is a breaking change that requires updating call sites (removing the context: label), it would be highly beneficial to document this explicitly in the changelog.
| - `ErrorContext` is now a non-nullable parameter. | |
| - `ErrorContext` is now a required positional, non-nullable parameter. |
as title
Pre-Review Checklist
[vector_math]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2