Skip to content

update fluentd to latest 1.19#661

Open
discostur wants to merge 26 commits into
fluent:mainfrom
discostur:bump-fluentd-version-1-19
Open

update fluentd to latest 1.19#661
discostur wants to merge 26 commits into
fluent:mainfrom
discostur:bump-fluentd-version-1-19

Conversation

@discostur

@discostur discostur commented Nov 18, 2025

Copy link
Copy Markdown

@discostur
update fluentd to latest 1.19
b5c5126 
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from 57371cc to b5c5126 Compare November 18, 2025 19:03
@discostur

discostur commented Jan 12, 2026

Copy link
Copy Markdown
Author

Could anybody please review / merge this?

@patrick-stephens

patrick-stephens commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Please can you rebase on the latest versions so we can bring in the updated CI?

@discostur

discostur commented Jan 22, 2026

Copy link
Copy Markdown
Author

@patrick-stephens done

@patrick-stephens

patrick-stephens commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

The DCO is a hard requirement for merge unfortunately so can you sort that? I think sometimes if you do the update via the web UI it messes up the signing.

@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from 9a6b3a3 to ed94515 Compare January 23, 2026 15:11
dependabot Bot and others added 14 commits January 23, 2026 16:13
@dependabot @discostur
build(deps): bump the github-actions group across 1 directory with 3 …
dbc62bf 
…updates (fluent#662)

Bumps the github-actions group with 3 updates in the / directory: [actions/setup-python](https://github.com/actions/setup-python), [helm/chart-testing-action](https://github.com/helm/chart-testing-action) and [helm/kind-action](https://github.com/helm/kind-action).

Updates `actions/setup-python` from 6.0.0 to 6.1.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@e797f83...83679a8)

Updates `helm/chart-testing-action` from 2.7.0 to 2.8.0
- [Release notes](https://github.com/helm/chart-testing-action/releases)
- [Commits](helm/chart-testing-action@0d28d31...6ec842c)

Updates `helm/kind-action` from 1.12.0 to 1.13.0
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](helm/kind-action@a1b0e39...92086f6)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: helm/chart-testing-action
  dependency-version: 2.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: helm/kind-action
  dependency-version: 1.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@Xelus22 @discostur
Update Chart.yaml (fluent#666)
63ef2c1 
Signed-off-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur
bump 1.19.1
536127e 
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur
improve debian version string
4218fe8 
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@stevehipwell @discostur
feat: Add fluent-bit charts for specific use cases (fluent#665)
04fdc19 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@stevehipwell @discostur
chore: Add artifact hub metadata (fluent#671)
f51581f 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@dependabot @discostur
build(deps): bump tj-actions/changed-files in the github-actions group (
5f8f68a 
fluent#672)

Bumps the github-actions group with 1 update: [tj-actions/changed-files](https://github.com/tj-actions/changed-files).

Updates `tj-actions/changed-files` from 47.0.0 to 47.0.1
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@24d32ff...e002140)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: 47.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@stevehipwell @discostur
chore: Update codeowners (fluent#678)
96bf2bd 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@dependabot @discostur
build(deps): bump the github-actions group with 2 updates (fluent#680)
8aa7944 
Bumps the github-actions group with 2 updates: [action-stars/helm-workflows/.github/workflows/release.yaml](https://github.com/action-stars/helm-workflows) and [action-stars/helm-workflows/.github/workflows/validate.yaml](https://github.com/action-stars/helm-workflows).

Updates `action-stars/helm-workflows/.github/workflows/release.yaml` from 0.8.11 to 0.9.0
- [Release notes](https://github.com/action-stars/helm-workflows/releases)
- [Changelog](https://github.com/action-stars/helm-workflows/blob/main/CHANGELOG.md)
- [Commits](action-stars/helm-workflows@25591df...36888a1)

Updates `action-stars/helm-workflows/.github/workflows/validate.yaml` from 0.8.11 to 0.9.0
- [Release notes](https://github.com/action-stars/helm-workflows/releases)
- [Changelog](https://github.com/action-stars/helm-workflows/blob/main/CHANGELOG.md)
- [Commits](action-stars/helm-workflows@25591df...36888a1)

---
updated-dependencies:
- dependency-name: action-stars/helm-workflows/.github/workflows/release.yaml
  dependency-version: 0.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
- dependency-name: action-stars/helm-workflows/.github/workflows/validate.yaml
  dependency-version: 0.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@stevehipwell @discostur
chore: Update tooling (fluent#685)
6874ae8 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@stevehipwell @discostur
feat(fluent-bit): Update image to v4.2.2 (fluent#684)
6a5df78 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@patrick-stephens @discostur
ci: add stale checks matching Fluent Bit (fluent#686)
01deb65 
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@marcofranssen @discostur
Update CODEOWNERS for fluent-operator chart
bb70bf9 
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@patrick-stephens @discostur
ci: make stale check manually triggerable (fluent#688)
9937c84 
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from beb166a to 9937c84 Compare January 23, 2026 15:14
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch 2 times, most recently from 857f2bb to 942f5f8 Compare March 16, 2026 14:23
@discostur
fix(fluentd): restore variant in default tag and update default to el…
d15636e 
…asticsearch7-1.0

As per review feedback, keep .Values.variant in the tag format so users
can still specify different image variants. Update the default variant
from 'elasticsearch7' to 'elasticsearch7-1.0' to match the full tag
pattern: v1.19.1-debian-elasticsearch7-1.0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from 942f5f8 to fb67042 Compare March 16, 2026 14:24
@discostur
bump version 1.19.2
29c4dd0 
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from 89d34ee to 29c4dd0 Compare March 16, 2026 14:43
@discostur
bump 1.19.2
404b544 
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur discostur force-pushed the bump-fluentd-version-1-19 branch from 22a511c to 404b544 Compare March 16, 2026 14:44
dioguerra
dioguerra previously approved these changes Mar 17, 2026
View reviewed changes
@dioguerra

dioguerra commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

@stevehipwell Should i just Merge? My confidence that this will explode if if i try to rebase is quite high....

@dioguerra

dioguerra commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Also will need to validate this new tests thing. Looks like the image is failing. If i remember correctly this will require to setup target instance configs...

@stevehipwell

stevehipwell commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

@dioguerra you need to rebase before you can merge.

@dioguerra

dioguerra commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

Will need to fix conflicts then, is @discostur still around?

@discostur

discostur commented Mar 30, 2026

Copy link
Copy Markdown
Author

@dioguerra done

@dioguerra

dioguerra commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

I dont think it will work because [Validate PR / Validate / Validate Helm charts (fluentd) (pull_request)](https://github.com/fluent/helm-charts/actions/runs/23760033861/job/69225079803?pr=661) needs to be fixed.

@stevehipwell

stevehipwell commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

It looks like the pod readiness check is failing. @discostur have you tested this locally? Also what about the warning about K8S_NODE_NAME?

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Jul 1, 2026
discostur and others added 2 commits July 1, 2026 09:49
@discostur
Merge branch 'main' into bump-fluentd-version-1-19
7a43d76
@discostur @claude
feat(fluentd): update Fluentd to v1.19.3
da78086 
Bumps the Fluentd daemonset image to v1.19.3 on top of the SemVer/
variantVersion refactor from fluent#720:

- appVersion 1.19.2 -> 1.19.3, chart version 0.5.3 -> 0.5.4
- variantVersion 1.6 -> 1.0 to match the published
  v1.19.3-debian-elasticsearch7-1.0 image (1.19.3 only has build
  revision 1.0 so far)
- set K8S_NODE_NAME from spec.nodeName so the kubernetes_metadata
  filter watches only the local node's pods, which removes the
  "K8S_NODE_NAME is not set" warning and reduces API server load
- CHANGELOG + helm-docs README regenerated for 0.5.4

Verified in a kind cluster: daemonset pod becomes ready, the
helm test-connection pod succeeds, and the K8S_NODE_NAME warning
is gone.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Kilian Ries <mail@kilian-ries.de>
@discostur

discostur commented Jul 1, 2026

Copy link
Copy Markdown
Author

Rebased onto the latest main and updated the chart to Fluentd v1.19.3.

What changed since the last review

  • Merged current main, so this now builds on top of @stevehipwell's SemVer + variantVersion refactor (chore(fluentd): add changelog #720) instead of the old variant: elasticsearch7-1.0 approach. Merge conflicts were resolved in favour of main, so the only net change this PR adds is the version bump below.
  • appVersion 1.19.2 → 1.19.3, chart version 0.5.3 → 0.5.4 (+ CHANGELOG / helm-docs README).
  • variantVersion 1.6 → 1.0: v1.19.3 currently only ships the v1.19.3-debian-elasticsearch7-1.0 daemonset image — there is no -1.6 build for 1.19.3 yet.

@stevehipwell — the K8S_NODE_NAME warning

Fixed. The pod template now sets K8S_NODE_NAME from spec.nodeName, so the kubernetes_metadata filter watches only the local node's pods. This removes the !! The environment variable 'K8S_NODE_NAME' is not set ... !! warning and reduces API-server/watch load.

On the failing pod-readiness / test check

Root cause was the test-connection helm-test pod: it carried the DaemonSet's selector labels (app.kubernetes.io/name + app.kubernetes.io/instance), so the DaemonSet controller treated it as a surplus daemon pod on the node and deleted it (SuccessfulDelete ... Deleted pod: <release>-fluentd-test-connection) → helm test failed. That's already fixed on main in #720, and this branch now picks it up.

Verification

Reproduced and verified locally in a kind cluster (k8s 1.33):

  • DaemonSet pod reaches Ready with image v1.19.3-debian-elasticsearch7-1.0
  • helm test → test-connection pod Succeeded
  • no K8S_NODE_NAME warning in the fluentd logs
  • helm lint clean

Ready for another look 🙏

@github-actions github-actions Bot removed the Stale label Jul 2, 2026
stevehipwell
stevehipwell approved these changes Jul 8, 2026
View reviewed changes

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell

stevehipwell commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

@discostur could you please rebase this?

@discostur

discostur commented Jul 8, 2026

Copy link
Copy Markdown
Author

@stevehipwell done

@stevehipwell

stevehipwell commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

@dioguerra do you want to give this a final review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell stevehipwell approved these changes
@dioguerra dioguerra dioguerra left review comments
@patrick-stephens patrick-stephens Awaiting requested review from patrick-stephens patrick-stephens is a code owner
@benjaminhuo benjaminhuo Awaiting requested review from benjaminhuo
@wanjunlei wanjunlei Awaiting requested review from wanjunlei
@wenchajun wenchajun Awaiting requested review from wenchajun
@marcofranssen marcofranssen Awaiting requested review from marcofranssen
@joshuabaird joshuabaird Awaiting requested review from joshuabaird
@edsiper edsiper Awaiting requested review from edsiper
@naseemkullah naseemkullah Awaiting requested review from naseemkullah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@discostur @patrick-stephens @stevehipwell @dioguerra @Xelus22 @marcofranssen