Skip to content

Ensure new if blocks translate properly when locales are changes #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracygardner merged 2 commits into from
Feb 19, 2026
Merged

Ensure new if blocks translate properly when locales are changes #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b9c45
Use Blockly strings for if, else if and else in new if block
Zishan-Rahman Feb 18, 2026
f8fc6f2
Implement missing else string overrides for locales that needed them
Zishan-Rahman Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions blocks/control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,9 +563,9 @@ export function defineControlBlocks() {
this.appendDummyInput("HEAD").appendField(
new Blockly.FieldDropdown(
[
["if", MODE.IF],
["else if", MODE.ELSEIF],
["else", MODE.ELSE],
["%{BKY_CONTROLS_IF_MSG_IF}", MODE.IF],
["%{BKY_CONTROLS_IF_MSG_ELSEIF}", MODE.ELSEIF],
["%{BKY_CONTROLS_IF_MSG_ELSE}", MODE.ELSE],
],
(newValue) => {
this.updateShape_(newValue);
Expand Down
2 changes: 1 addition & 1 deletion locale/de.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ export default {
CONTROLS_FOR_INPUT_DO: "",
CONTROLS_FOREACH_INPUT_DO: "",
CONTROLS_IF_MSG_THEN: "",
CONTROLS_IF_MSG_ELSE: "else\n",
CONTROLS_IF_MSG_ELSE: "sonst\n",
CONTROLS_FOR_TITLE: "für jede(n) %1 von %2 bis %3 mit Schritt %4",

// Block messages
Expand Down
2 changes: 1 addition & 1 deletion locale/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export default {
CONTROLS_FOR_INPUT_DO: "", // human
CONTROLS_FOREACH_INPUT_DO: "", // human
CONTROLS_IF_MSG_THEN: "", // human
CONTROLS_IF_MSG_ELSE: "else\n", // human
CONTROLS_IF_MSG_ELSE: "sino\n", // human
CONTROLS_FOR_TITLE: "para cada %1 desde %2 hasta %3 por %4", // human

// Block message translations
Expand Down
2 changes: 1 addition & 1 deletion locale/pl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ export default {
CONTROLS_FOR_INPUT_DO: "",
CONTROLS_FOREACH_INPUT_DO: "",
CONTROLS_IF_MSG_THEN: "",
CONTROLS_IF_MSG_ELSE: "else\n",
CONTROLS_IF_MSG_ELSE: "w przeciwnym razie\n",
CONTROLS_FOR_TITLE: "dla każdego %1 od %2 do %3 co %4",

// Block message translations
Expand Down