Open
Conversation
Skn0tt
reviewed
Sep 17, 2024
Collaborator
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Hi! I'm generally supportive of this addition. Could you add some tests for it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #294. Implements support for the relatively new but widely supported AggregateError type. This is a subclass of Error which supports passing an array of child errors. As an example this is useful if you need to make a series of network requests to load a page, you can return a single error which captures all the related failures.
I figured this would be more controversial than the #296 change so separated the 2. This duplicates some of the changes but only to provide complete implementation for this MR. I thought it best to introduce it as a separate transformer for backwards compatibility.
Adds type check for AggregateError