Merged
Conversation
Implements universe-based event tracking for key UI components following
dot notation naming convention (ui.{component}.{action}).
Components updated:
- Button: Opt-in event tracking via @eventName and @eventargs
- Modal Manager: Automatic ui.modal.opened and ui.modal.closed events
- Dropdown Button: Opt-in event tracking when dropdown opens
- Filters Picker: Automatic ui.filter.applied and ui.filter.cleared events
Event naming follows pattern: ui.{component}.{action}
Examples: ui.button.clicked, ui.modal.opened, ui.filter.applied
All events are emitted through universe service's Evented interface.
Events are analytics-agnostic and can be consumed by any analytics
system (PostHog, Google Analytics, Mixpanel, etc.).
Benefits:
- OSS-friendly: No proprietary analytics code in ember-ui
- Extensible: Easy to add events to new components
- Flexible: Consumers choose which events to track
- Non-breaking: All tracking is opt-in or automatic
See ANALYTICS_EVENTS.md for complete documentation and usage examples.
…se.trigger() - Updated all components to use @service events - Changed universe.trigger() calls to events.trackEvent() - Updated modals-manager service to use events service - Rewrote documentation to explain dual event system Components updated: - button.js - dropdown-button.js - filters-picker.js Services updated: - modals-manager.js Benefits: - Dual event system: events.on() and universe.on() - Consistent with ember-core events service architecture - Automatic enrichment with user/org/timestamp metadata - Cleaner abstraction over raw universe.trigger() calls
feat: Add analytics-agnostic events to UI components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.