Merged
Conversation
CMS: - Add :note-category/order, :modules, :translation-key to schema - Add :application/note-categories sub and table-entity-form editor - entity-form: resolve :db/id on ref-cardinality-many retractions so editing an existing note-category's module set doesn't ghost old refs App wiring: - :vms/note-categories now returns the shaped pull; new :wizard/note-categories filters by worksheet module set - Standard wizard page: swap :vms/note-categories for the filtered sub and pass modules to wizard-notes - c/note: use shared dropdown component, add Cancel with dirty-check discard-confirm, require a selected category before Save - Wizard note list: confirm before Delete, move Edit/Delete onto the note-title row - Translated Cancel / discard / delete-confirm strings Migration: - development/migrations/2026_04_21_add_note_categories.clj seeds Fuel Model / Fuel Moisture / Weather / Topography / Fire Behavior (all-module), Canopy Fuel (SURFACE+CROWN), Resources (SURFACE+CONTAIN), Mortality (SURFACE+MORTALITY), plus English translations for the new category names and UI confirm strings Styling: - .note__category-select: horizontal flex, 14px medium labels on one line, Category label inline-left of the dropdown - .note__footer: Cancel and Save grouped adjacent on the right - .wizard-note__header: title + Edit/Delete share one row
Collaborator
|
Looks Good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds Notes Categories Editor to VMS, updates Notes to use Categories
Related Issues
Closes BHP1-1480
Submission Checklist
BHP1-### <title>)clj-kondo --lint components/**/src bases/**/src projects/**/src)clojure -M:compile-cljs)Testing
migrations.2026-04-21-add-note-categories, sync