fix(react): ensure that display name is updated upon sign up if requireDisplayName() behaviour is invoked#1346
Draft
russellwheatley wants to merge 5 commits intomainfrom
Draft
fix(react): ensure that display name is updated upon sign up if requireDisplayName() behaviour is invoked#1346russellwheatley wants to merge 5 commits intomainfrom
russellwheatley wants to merge 5 commits intomainfrom
Conversation
…ayName() behaviour is invoked
There was a problem hiding this comment.
Code Review
This pull request introduces a deduplication mechanism for sign-up events in the SignUpAuthScreen component across both the react and shadcn packages. By utilizing a useRef to track handled user IDs and making the useOnUserAuthenticated hook conditional, the implementation ensures that sign-up callbacks are not triggered redundantly when the form itself handles the success. The changes also include comprehensive test updates to verify the new deduplication logic and hook behavior. Review feedback suggests enhancing type safety in test mocks and maintaining type consistency for the user parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1344
Here's React example app with
requireDisplayName()behaviour enabled:Screen.Recording.2026-03-26.at.15.57.36.mov