Skip to content

chore: modify release flow in light of security changes#10144

Merged
hsubox76 merged 9 commits into
mainfrom
ch-release-revamp
Jul 13, 2026
Merged

chore: modify release flow in light of security changes#10144
hsubox76 merged 9 commits into
mainfrom
ch-release-revamp

Conversation

@hsubox76

@hsubox76 hsubox76 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
  1. Change release-pr.yml (run at staging, bumps versions and generates release PR) so that the changesets action sets "setupGitUser" to false. This should hopefully remove the "github-actions" bot as a co-author, which causes the CLA check to fail on PRs.

  2. Remove OSS_BOT_GITHUB_TOKEN from release-prod checkout. This was an attempt a while back to try to fix an engprod workflow that was supposed to be triggered by the prod release workflow and wasn't triggering. It didn't work anyway and that workflow no longer exists. With this removed, it will just use the default GITHUB_TOKEN like every other checkout action in our workflows.

  3. Split the github tag publish step out of the main release script into a separate script, and execute this at the end of the prod release workflow so that it doesn't block any other steps. (But before github release publish because that depends on the new tag existing.) I don't want to use continue-on-error because I still want it to fail the workflow with a big red symbol so we know we have to manually push the git tags. But I want the other steps to be able to complete.

I can't really test any of this until the next release without running a release so I guess let's check it very carefully.

@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 45c533d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts the logic for pushing release tags to GitHub into a standalone script publish-git-tags.js and removes it from the main release script. Feedback on these changes highlights three key issues: first, importing TypeScript utilities from a JavaScript file will cause runtime failures, so the script should be renamed to .ts; second, the script needs to handle cases where no tags point to HEAD to avoid pushing empty strings; and third, the asynchronous entry point should catch errors and exit with a non-zero code to ensure CI workflows fail correctly.

Comment thread scripts/release/publish-git-tags.ts
Comment thread scripts/release/publish-git-tags.ts
Comment thread scripts/release/publish-git-tags.ts
Comment thread .github/workflows/release-prod.yml
@hsubox76
hsubox76 marked this pull request as ready for review July 10, 2026 01:03
@hsubox76
hsubox76 requested a review from a team as a code owner July 10, 2026 01:03
Comment thread .github/workflows/release-pr.yml
Comment thread scripts/release/publish-git-tags.ts
Comment thread scripts/release/publish-git-tags.ts Outdated
Comment thread .github/workflows/release-prod.yml
@hsubox76
hsubox76 merged commit e7a3f28 into main Jul 13, 2026
42 of 44 checks passed
@hsubox76
hsubox76 deleted the ch-release-revamp branch July 13, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants