chore(build): Add the GitHub token to Publish to NPM of Production Release#10139
Open
DellaBitta wants to merge 1 commit into
Open
chore(build): Add the GitHub token to Publish to NPM of Production Release#10139DellaBitta wants to merge 1 commit into
Publish to NPM of Production Release#10139DellaBitta wants to merge 1 commit into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
A previous security fix restricted which steps the GitHub token would have access to. Previously the GitHub token was configured in the checked step of
.github/workflows/release-prod.ymland the subsequent steps would inherit it. But now, withpersist-credentials: false, the token's TTL is only that one step.But we need the token for the
yarn releasescript as well.This explictly sets the token using
gitcommands, then runsyarn releaseand then removes the token.Testing
CI
API Changes
None.