Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 21, 2026

To make it easier to work between both type sets, the converters group together the code necessary for communication between SDKs in a single point.

To make it easier to work between both type sets, the converters group
together the code necessary for communication between SDKs in a single
point.
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@rlazo
Copy link
Collaborator Author

rlazo commented Jan 21, 2026

/gemini review

@google-oss-bot
Copy link
Collaborator

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new file with converter functions to translate between ML Kit and interop data types. The implementation is mostly straightforward, but I've found a significant bug where the image part of a request is ignored during conversion. I've provided a suggestion to fix this. I also included a minor suggestion to make the code more idiomatic and concise. Overall, good work on centralizing the conversion logic.

@rlazo
Copy link
Collaborator Author

rlazo commented Jan 22, 2026

The code in this PR depends on #7663 landing, so it won't build before that PR lands.

@rlazo rlazo merged commit 7a78be5 into feature/hybrid Jan 22, 2026
26 checks passed
@rlazo rlazo deleted the rlh.converters branch January 22, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants