-
Notifications
You must be signed in to change notification settings - Fork 664
[AI] Add converter functions to translate mlkit and interop #7665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To make it easier to work between both type sets, the converters group together the code necessary for communication between SDKs in a single point.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new file with converter functions to translate between ML Kit and interop data types. The implementation is mostly straightforward, but I've found a significant bug where the image part of a request is ignored during conversion. I've provided a suggestion to fix this. I also included a minor suggestion to make the code more idiomatic and concise. Overall, good work on centralizing the conversion logic.
firebase-ai-ondevice/src/main/kotlin/com/google/firebase/ai/ondevice/Converters.kt
Show resolved
Hide resolved
firebase-ai-ondevice/src/main/kotlin/com/google/firebase/ai/ondevice/Converters.kt
Show resolved
Hide resolved
|
The code in this PR depends on #7663 landing, so it won't build before that PR lands. |
To make it easier to work between both type sets, the converters group together the code necessary for communication between SDKs in a single point.