Skip to content

[AI] Address comments left in PR #7656 #7664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlazo merged 1 commit into from
Jan 22, 2026
Merged

[AI] Address comments left in PR #7656 #7664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...otlin/com/google/firebase/ai/ondevice/interop/FirebaseAIOnDeviceGenerativeModelFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ public interface FirebaseAIOnDeviceGenerativeModelFactory {
*
* @return A new [GenerativeModel] instance ready for use.
*/
public fun getGenerativeModel(): GenerativeModel
public fun newGenerativeModel(): GenerativeModel
}
2 changes: 1 addition & 1 deletion ...i-ondevice/src/main/kotlin/com/google/firebase/ai/ondevice/FirebaseAIOnDeviceComponent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ import com.google.firebase.ai.ondevice.interop.GenerativeModel
*/
internal class FirebaseAIOnDeviceComponent : FirebaseAIOnDeviceGenerativeModelFactory {

override fun getGenerativeModel(): GenerativeModel = GenerativeModelImpl()
override fun newGenerativeModel(): GenerativeModel = GenerativeModelImpl()
}
2 changes: 1 addition & 1 deletion subprojects.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ appcheck:firebase-appcheck # sdk

firebase-abt # sdk
firebase-ai # sdk
firebase-ai-ondevice-interop # sdk
firebase-ai-ondevice # sdk
firebase-ai-ondevice-interop # sdk
firebase-annotations # sdk
firebase-appdistribution # sdk
firebase-appdistribution-api # sdk
Expand Down
Loading