Feature: Add ZIP encoding selection support for browsing archives with non-UTF-8 filenames

[oxygen-dioxide]

Problem
When opening a ZIP archive whose filenames use an encoding other than the user's OS encoding, the filenames appear garbled

Solution
Added a ComboBox in the navigation toolbar that appears when browsing a ZIP archive with undetermined encoding, allowing the user to select the appropriate character encoding. When a custom encoding is selected, the app switches from SevenZipSharp to SharpZipLib to read filenames and file contents.

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Bug: File names for Japanese zips aren't shown correctly on Chinese language #14937

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Download this zip file: japanese-example.zip
2. In Files, double click this file to open it
3. Select "Japanese (Shift-JIS)" encoding

previous behaviour:

current behaviour:

[oxygen-dioxide]

Problem: users still can't double-click a file in the archive to open it because process.Start() doesn't support custom zip encoding. (However, this bug also occurs for 7z files, so I may create another PR to fix it.)

[oxygen-dioxide]

moved the combobox to bottom right corner

[yair100]

Thanks! I'd like to take a closer look and get some feedback from @mdtauk but I can already tell that the overall location looks a lot better in that screenshot.

[yair100]

What do you think about replacing the ComboBox with a Button and Flyout like we do for git branches? Please let me know if you want me to push a commit.

[oxygen-dioxide]

What do you think about replacing the ComboBox with a Button and Flyout like we do for git branches? Please let me know if you want me to push a commit.

Looks good to me

[yair100]

What's the expected behavior when opening a regular zip file?

[oxygen-dioxide]

• src/Files.App/Data/Items/EncodingItem.cs — Changed the built-in Chinese encoding from gb2312 to gb18030, which is a strict superset and matches the encoding name returned by DetectEncodingAsync.
• src/Files.App/Services/Storage/StorageArchiveService.cs — In IsEncodingUndeterminedAsync, entries whose names consist entirely of ASCII characters are now considered determined (not undetermined), even if they don't declare Unicode. This avoids showing the encoding picker when the zip content is pure ASCII and doesn't need a specific non-UTF-8 encoding.
• src/Files.App/Data/Models/DirectoryPropertiesViewModel.cs (the StatusBarViewModel) — When auto-detect finds an encoding not present in the built-in list, it dynamically creates an EncodingItem for it and appends it to the options, ensuring the detected encoding always appears in the dropdown.

[oxygen-dioxide]

What's the expected behavior when opening a regular zip file?

For ascii or utf-8 zip file, the encoding selector shouldn't show up. I've fixed my code.

[0x5bfa]

CI is now failing and most of my reviews are still present.

[oxygen-dioxide]

I've fixed all the problems you listed here. I think we can continue now.

[CLAassistant]

All committers have signed the CLA.

[0x5bfa]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c186541403

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[oxygen-dioxide]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[oxygen-dioxide]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0dce64265

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[yair100]

LGTM

[yair100]

While everything works fine on my end, Claude requested a couple of changes. It might be worth addressing them before we merge.

• StatusBarViewModel is created per layout page but the new ContentPageContext.PropertyChanged += ... subscription is never removed, so every navigation leaks a view model instance. Needs an unsubscribe path.
• IPasswordProtectedItem.cs: ZipException.Message.Contains("encrypted") matches "No password available for encrypted stream" but not "Invalid password", so a mistyped password won't re-prompt. Also match "password" (or check entry.IsCrypted).
• ZipStorageFolder.GetBasicPropertiesWithEncodingAsync / GetItemWithEncodingAsync compare entry paths with case-sensitive == while everything else uses OrdinalIgnoreCase — case-different names miss.
• CopyWithEncodingAsync buffers the whole entry into a MemoryStream before writing (the SevenZip path streams directly) — extracting a large file will spike memory. Copy zipFile.GetInputStream(entry) straight to the destination stream.
• GetItemsWithEncodingAsync, GetItemWithEncodingAsync, and OpenSequentialReadWithEncodingAsync are missing the SafetyExtensions.Wrap(..., RetryWithCredentialsAsync) wrapper all sibling methods use — no password prompt on failure.

[Josh65-2201]

Only issue is that the folder doesn't reload correctly when changing the encoding, I have to back out and go back in. It's selecting the correct type and loading correctly when opened so it minor.