Skip to content

Added Unitx Test, for the GetGoalsForUser route in the GoalController - #327

Open
GitLilee wants to merge 8 commits into
fencer-so:mainfrom
GitLilee:test-icons
Open

Added Unitx Test, for the GetGoalsForUser route in the GoalController#327
GitLilee wants to merge 8 commits into
fencer-so:mainfrom
GitLilee:test-icons

Conversation

@GitLilee

@GitLilee GitLilee commented Aug 5, 2026

Copy link
Copy Markdown

Adds a unit test for the GetForUser route in GoalController, covering the case where goals are fetched for a specific user.

The test verifies:

  • The result is not null
  • Each returned goal is assignable from Goal
  • Each returned goal's UserId matches the requested user

This was written alongside the icon/emoji picker feature for goals, to help ensure the GoalController continues to behave correctly as that work lands.

Files changed:

  • GoalControllerTests.cs

Testing:

Ran dotnet test locally
--> all tests pass.

@gitguardian

gitguardian Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials d78f277 CommBank-Server/Secrets.json View secret
- - MongoDB Credentials 8d09e21 CommBank-Server/Secrets.json View secret
- - MongoDB Credentials 0279de3 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant