7062 State Filters

[rfultz]

Summary

• Resolves Add state equivalents to state filter of multiple data tables #7062

Required reviewers

• dev
• SME

Impacted areas of the application

• Combined/re-arranged the states lists in constants.py
  • Updated constants.states not to include the territories
  • Removed states_excl_territories in favor of states
  • Pulled the territories into their own OrderedDict
  • Created armed_forces OrderedDict
  • Created states_territories OrderedDict (a combination of states and territories)
  • Created states_all_contributors OrderedDict (a combination of states, territories, armed forces, and ZZ)
  • Updated election-lookup.jinja to use constants.states_territories instead of constants.states
  • Updated candidates-single.jinja to use constants.states_territories instead of constants.states
  • Updated pres-finance-map.jinja to refer to states instead of states_excl_territories
• Changed from filters/contributor-states.jinja to filters/contributor-states.jinja
• Added a parameter (list_type) to filters/states.jinja to use different (states, etc) lists
• Removed filters/contributor-states.jinja
• Updated the various templates/partials/*-filter.jinja to use states.jinja and list_type

Screenshots

They should all now look like…

Related PRs

None

How to test

• Pull branch
• npm i just in case
• npm run build
• ./manage.py runserver
• These state filters all include options for territories, armed forces, and ZZ/foreign/other
  • Receipts http://127.0.0.1:8000/data/receipts/
  • Individual contributions http://127.0.0.1:8000/gov/data/receipts/individual-contributions/
  • National party account receipts http://127.0.0.1:8000/data/national-party-account-receipts/
  • National party account disbursements http://127.0.0.1:8000/data/national-party-account-disbursements/
  • Disbursements http://127.0.0.1:8000/data/disbursements/
  • Independent expenditures http://127.0.0.1:8000/data/independent-expenditures/
  • Allocated federal nonfederal disbursements http://127.0.0.1:8000/data/allocated-federal-nonfederal-disbursements/
  • Committees http://127.0.0.1:8000/data/committees/
  • Political action and party committees http://127.0.0.1:8000/data/committees/pac-party/
• These uses of the states list are unaffected
  • Presidential map
  • http://127.0.0.1:8000/data/elections/house/
  • http://127.0.0.1:8000/data/elections/senate/
  • http://127.0.0.1:8000/data/elections/president/
  • http://127.0.0.1:8000/data/elections/house/al/01/
  • https://www.fec.gov/data/elections/senate/al/2026/

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.20%. Comparing base (781112a) to head (bb872e0).
⚠️ Report is 12 commits behind head on develop.

Files with missing lines	Patch %	Lines
fec/data/views.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7147   +/-   ##
========================================
  Coverage    79.20%   79.20%           
========================================
  Files          255      255           
  Lines         6664     6666    +2     
========================================
+ Hits          5278     5280    +2     
  Misses        1386     1386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[patphongs]

@rfultz Good work on this. Here's some fixes needed:

1. Need to update filters to constants.states_territories, otherwise we get an error on territories like this: http://localhost:8000/data/elections/house/pr/00/2024/
   

   fec-cms/fec/data/templatetags/filters.py

   Line 120 in 781112a

   return constants.states[value.upper()]

2. Need to update to constants.states_territories
   

   fec-cms/fec/data/templates/partials/committee/about-committee.jinja

   Line 150 in 781112a

   <p class="callout__subtitle u-no-margin">{{ constants.states[candidate.state] }} | {{ candidate.party_full |capitalize}}</p>

3. Need to update to constants.states_territories
   

   fec-cms/fec/data/templates/partials/candidate/about-candidate.jinja

   Line 20 in 781112a

   <td class="figure__value">{% if constants.states[state] %}{{ constants.states[state] }} {% endif %}{{ office_full }}{% if office_full == 'House' %} District {{ district|strip_zero_pad }}{% endif %}</td>

4. Need to update to constants.states_territories
   

   fec-cms/fec/data/templates/partials/candidate/about-candidate.jinja

   Line 59 in 781112a

   View all candidates in the {% if election_year %}{{ election_year }} {% endif %}{% if constants.states[state] %}{{ constants.states[state] }}{% endif %} {% if office == 'P' %}Presidential{% else %}{{ office_full }}{% endif %}{% if office_full == 'House' %} District {{ district|strip_zero_pad }}{% endif %} election

5. Let's go ahead and update tests here to cover assertions for state_full with territories and state lists that include territories. You'll also need to import from data the constants for these tests.
   

   fec-cms/fec/data/tests/test_utils.py

   Line 28 in 781112a

   def test_fmt_state_full(self):

Example:

assert filters.fmt_state_full('pr') == 'Puerto Rico'

New test:

def test_state_lists_include_territories(self):
        assert constants.territories['AS'] == 'American Samoa'
        assert constants.states_territories['AS'] == 'American Samoa'
        assert constants.states_all_contributors['AS'] == 'American Samoa'

[patphongs]

This looks to be missing on the list of territories:

('AS', 'American Samoa'),

[rfultz]

Oooh, nice catch! (Looks like it's in the territories list as 'AS' and the countries list as 'ASM')

[patphongs]

Need to update to list_type='states_territories'

[patphongs]

Need to update to list_type='states_territories'