Add minimum heights for FECfile+ widget - #7123
Merged
Merged
Conversation
JonellaCulmer
requested review from
patphongs
and removed request for
johnnyporkchops
June 3, 2026 17:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7123 +/- ##
========================================
Coverage 79.39% 79.39%
========================================
Files 256 256
Lines 6727 6727
========================================
Hits 5341 5341
Misses 1386 1386 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@rfultz I am unable to scroll when I shrink my window down. Is there something that I'm missing?
|
Contributor
|
@rfultz I reviewed but was seeing some weirdness with the scroll on the right. Seems to jump out of the box but I don't see that happen on other modals we use, like the legal boolean modal. Maybe we can pair on it and look at Pat's comment as well? Happy to find a time for the three of us so we can unblock you and this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Added some minimum heights for the FECfile+ eligibility widget because shorter displays were too short
Required reviewers
Impacted areas of the application
The FECfile+ eligibility widget
Screenshots
End state photos of bottom nav (because that's the longest/tallest content)
Related PRs
None
How to test
-Pull the branch
npm run build./manage.py runserver<button class="button js-launch-fecfile-eligibility">FECfile+</button>(It can be an<a>or<button>. The important part is thejs-launch-fecfile-eligibilityclass)