Skip to content

Add minimum heights for FECfile+ widget - #7123

Merged
patphongs merged 5 commits into
developfrom
feature/7122-fecfile-widget-height
Jul 30, 2026
Merged

Add minimum heights for FECfile+ widget#7123
patphongs merged 5 commits into
developfrom
feature/7122-fecfile-widget-height

Conversation

@rfultz

@rfultz rfultz commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Added some minimum heights for the FECfile+ eligibility widget because shorter displays were too short

Required reviewers

  • UX?
  • Dev for approach

Impacted areas of the application

The FECfile+ eligibility widget

Screenshots

End state photos of bottom nav (because that's the longest/tallest content)

image image

Related PRs

None

How to test

-Pull the branch

  • npm run build
  • ./manage.py runserver
  • In localhost Wagtail admin, edit a page to include an HTML block with this: <button class="button js-launch-fecfile-eligibility">FECfile+</button> (It can be an <a> or <button>. The important part is the js-launch-fecfile-eligibility class)
  • Open that page in your browser
  • Click your shiny new button (or link)
  • Click 'Get started'
  • Shrink the height of your browser window so the bottom nav is no longer visible
  • Scrolling to the bottom nav is now possible
  • Can navigate through the app in the smallest width
  • Can navigate through the app in the largest width
  • Can navigate through the app just under the breakpoint width
  • Can navigate through the app just over the breakpoint width
  • If you'd prefer, you can undo your change to that page

@rfultz rfultz added this to the 31.i milestone May 22, 2026
@rfultz rfultz self-assigned this May 22, 2026
@rfultz rfultz moved this to 👀 Ready in Website project May 22, 2026
@rfultz rfultz modified the milestones: 31.i, 32.1 Jun 2, 2026
@JonellaCulmer
JonellaCulmer requested review from patphongs and removed request for johnnyporkchops June 3, 2026 17:29
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.39%. Comparing base (38054b5) to head (c576d54).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7123   +/-   ##
========================================
  Coverage    79.39%   79.39%           
========================================
  Files          256      256           
  Lines         6727     6727           
========================================
  Hits          5341     5341           
  Misses        1386     1386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patphongs

Copy link
Copy Markdown
Member

@rfultz I am unable to scroll when I shrink my window down. Is there something that I'm missing?

Screenshot 2026-06-15 at 3 37 26 PM

@rfultz rfultz modified the milestones: 32.1, 32.3 Jun 30, 2026
@rfultz rfultz modified the milestones: 32.3, 32.4 Jul 14, 2026
@JonellaCulmer

Copy link
Copy Markdown
Contributor

@rfultz I reviewed but was seeing some weirdness with the scroll on the right. Seems to jump out of the box but I don't see that happen on other modals we use, like the legal boolean modal. Maybe we can pair on it and look at Pat's comment as well? Happy to find a time for the three of us so we can unblock you and this work.

@kathycarothers kathycarothers modified the milestones: 32.4, 32.5 Jul 28, 2026

@patphongs patphongs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfultz Looks good, the scroll only jumps slightly out of the dialog, but it's really minor and can be fixed later.

@patphongs
patphongs merged commit 655e5dc into develop Jul 30, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 Ready to ✅ Done in Website project Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Unable to access FECfile+ buttons on smaller screens

4 participants