Open
Conversation
maltanar
requested changes
Feb 27, 2023
Collaborator
maltanar
left a comment
There was a problem hiding this comment.
Hi @selwyn96 , thanks for the PR. To keep this consistent with the rest of the qonnx docs (viewable online on https://qonnx.readthedocs.io/ or can be built with tox -e docs) I'd like to request a couple of changes:
- Instead of having this as a standalone Markdown file, could you add this as ReStructured Text (rst) to the documentation under https://github.com/fastmachinelearning/qonnx/tree/main/docs and link it from the toctree under https://github.com/fastmachinelearning/qonnx/blob/main/docs/index.rst ?
- Can you elaborate a bit more on the stability issue for ternary quantization? What can the user expect, what is the symptom/bug that will arise here?
- Can you add a link to the relevant test(s) in the test suite that the users can look at as reference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the documentation outlining the limitation of the current Qkeras converter.