Add Hcal reco producer with FACILE algorithm#1
Open
jeffkrupa wants to merge 20 commits intofastmachinelearning:masterfrom
Open
Add Hcal reco producer with FACILE algorithm#1jeffkrupa wants to merge 20 commits intofastmachinelearning:masterfrom
jeffkrupa wants to merge 20 commits intofastmachinelearning:masterfrom
Conversation
added 15 commits
October 2, 2020 15:45
kpedro88
reviewed
Oct 9, 2020
| iEvent.put(std::move(out)); | ||
| } | ||
|
|
||
| /*static void fillDescriptions(edm::ConfigurationDescriptions & descriptions) { |
There was a problem hiding this comment.
reactivate this and provide the necessary parameters
(just ChannelInfoName based on the constructor?)
|
after implementing review comments: run then we can squash the branch so the old changes to the HLT config, etc. are eliminated |
kpedro88
reviewed
Oct 13, 2020
kpedro88
reviewed
Oct 13, 2020
added 3 commits
October 13, 2020 21:57
Author
|
Thanks for your review! all changes were implemented and checks completed. |
kpedro88
reviewed
Oct 14, 2020
kpedro88
pushed a commit
that referenced
this pull request
Jul 9, 2021
Remove boost::bind dependency
kpedro88
pushed a commit
that referenced
this pull request
Feb 17, 2024
…30-2300 From cmssw 14 0 x 2023 11 30 2300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
HcalReconstructorconsumes HBHEChannelInfo and produces HBHERecHit