Ensure that the hostname has a port number when building pushpin routes #1631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR adds a port number if not specified when building Pushpin routes from fastly.toml, when experimental pushpin is enabled.
Given the following
fastly.tomlfile:Before the fix, without the port number, Pushpin throws an error during initialization:
routes
pushpin-proxy.log
After this fix:
routes
pushpin-proxy.log
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Are there any considerations that need to be addressed for release?