Skip to content

Conversation

@harmony7
Copy link
Member

Change summary

This PR adds a port number if not specified when building Pushpin routes from fastly.toml, when experimental pushpin is enabled.

Given the following fastly.toml file:

[local_server.pushpin]
enable = true

[local_server.backends]
[local_server.backends.origin]
url = "https://example.com/"
override_host = "example.com"

[local_server.backends.self]
url = "http://localhost:7676/"
override_host = "localhost:7676"

Before the fix, without the port number, Pushpin throws an error during initialization:

routes

id=origin example.com,over_http,ssl,host=example.com
id=self localhost:7676,over_http,host=localhost:7676

pushpin-proxy.log

[DEBUG] 2026-01-23 14:56:04.572 starting...
[WARN] 2026-01-23 14:56:04.576 /var/folders/ww/gnnpyf154zn_rd2fy12th2zxljyppv/T/pushpin-routes-0c353e5c:1: target bad format
[DEBUG] 2026-01-23 14:56:04.576 routes by domain:
[INFO] 2026-01-23 14:56:04.576 routes loaded with 1 entries
[DEBUG] 2026-01-23 14:56:04.580 worker 0: started
[INFO] 2026-01-23 14:56:04.580 started

After this fix:

routes

id=origin example.com:443,over_http,ssl,host=example.com
id=self localhost:7676,over_http,host=localhost:7676

pushpin-proxy.log

[DEBUG] 2026-01-23 18:33:49.755 starting...
[DEBUG] 2026-01-23 18:33:49.757 routes by domain:
[INFO] 2026-01-23 18:33:49.757 routes loaded with 2 entries
[DEBUG] 2026-01-23 18:33:49.760 worker 0: started
[INFO] 2026-01-23 18:33:49.760 started

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Are there any considerations that need to be addressed for release?

@harmony7 harmony7 self-assigned this Jan 23, 2026
@harmony7 harmony7 requested a review from a team as a code owner January 23, 2026 09:35
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harmony7 harmony7 enabled auto-merge (squash) January 24, 2026 06:57
@harmony7 harmony7 merged commit 9818325 into main Jan 24, 2026
13 checks passed
@harmony7 harmony7 deleted the kats/pushpin-port branch January 24, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants