-
-
Notifications
You must be signed in to change notification settings - Fork 791
🚨 Fix Type of "Field" is partially unknown with Pyright in strict mode
#1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🚨 Fix Type of "Field" is partially unknown with Pyright in strict mode
#1644
Conversation
|
This is a more suitable alternative to #1604 as it keeps the |
Type of "Field" is partially unknown with Pyright in strict mode
YuriiMotov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue and solution looks good to me.
To reproduce the issue, create main.py with:
# pyright: strict
from sqlmodel import FieldAnd run:
pip install pyright
pyright main.py@mpyuglgwkxcmodyrpo, thanks!
|
That's awesome! I hope the version with these changes gets released soon. |
|
@tiangolo @YuriiMotov I'm wondering when this PR will be added to the release. |
|
This pull request has a merge conflict that needs to be resolved. |
1 similar comment
|
This pull request has a merge conflict that needs to be resolved. |
|
I have confirmed that the issue has been resolved in the newly released |
See #1598 for discussion. I wanted to see if this would pass tests across the matrix (don't see why they wouldn't).
I think this only applies to pyright in strict mode.
I can't edit lables, so someone should add the bug label or whatever else is relevant.