[docs] fix favicon and RSS logo URLs using public/ directory#1653
Open
henryqdineen wants to merge 1 commit into
Open
[docs] fix favicon and RSS logo URLs using public/ directory#1653henryqdineen wants to merge 1 commit into
henryqdineen wants to merge 1 commit into
Conversation
Follow-up to facebook#1648, which appears not to be working as expected — the deployed site serves `<link href="/assets/favicon-BDu8Z21d.svg">` but that URL returns 404. Claude researched the @vitejs/plugin-rsc build pipeline and has a theory: the Vite asset cache may be shared between the scan build (write=false) and the actual build, causing emitFile() to only be called in the throw-away scan context. The actual RSC bundle would then never include the file as a Rollup asset, so copyServerAssetsToClient has nothing to copy to dist/public/assets/. This was not confirmed. Fix: move favicon.svg and stylex-logo-small.svg to public/, which Waku copies verbatim to dist/public/ regardless of the asset pipeline. Hardcode the stable paths /favicon.svg and /stylex-logo-small.svg instead of using Vite asset imports. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
henryqdineen
requested review from
mellyeliu,
nmn and
vincentriemer
as code owners
|
@henryqdineen is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1648, which appears not to be working as expected — the deployed site serves
<link href="/assets/favicon-BDu8Z21d.svg">but that URL returns 404.Claude researched the
@vitejs/plugin-rscbuild pipeline and has a theory: the Vite asset cache may be shared between the scan build (write=false) and the actual build, causingemitFile()to only be called in the throw-away scan context. The actual RSC bundle would then never include the file as a Rollup asset, socopyServerAssetsToClienthas nothing to copy todist/public/assets/. This was not confirmed.Fix: move
favicon.svgandstylex-logo-small.svgtopublic/, which Waku copies verbatim todist/public/regardless of the asset pipeline. Hardcode the stable paths/favicon.svgand/stylex-logo-small.svginstead of using Vite asset imports.