Add Sonatype Central repository for users of nightly builds only #55305
+58
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Even though Sonatype Central repository isn't used by an app, still the React Native Gradle plugin adds the Sonatype Central to repositories. In some cases it leads to a considerable amount of failed requests on Gradle downloading dependencies. I'm introducing a Gradle property to control if Sonatype Central should be included by default or not. User can control this behavior by changing their `gradle.properties` file as such: ``` includeSonatypeRepository=false ``` The default value of this property is true Changelog: [Android] [Added] - Make the addition of Sonatype Central repository configurable
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
That's not the right approach. Instead we should add the snapshot repository only if you're using a nightly version of React Native. |
Summary: Even though Sonatype Central repository isn't used by an app, still the React Native Gradle plugin adds the Sonatype Central to repositories. In some cases it leads to a considerable amount of failed requests on Gradle downloading dependencies. I'm introducing a change where Sonatype Central repository is included for users of nightly builds only. Changelog: [ANDROID] [CHANGED] - Add Sonatype Central repository for users of nightly builds only
sergeich
changed the title
Author
@cortinico Ah, I see, thank you I've changed the PR accordingly :) |
cortinico
approved these changes
Jan 28, 2026
Comment on lines
+281
to
+282
| private fun String.isNightly(): Boolean = | ||
| this.startsWith("0.0.0") || "-nightly-" in this |
Contributor
There was a problem hiding this comment.
Could you write some unit tests for this function as well?
| val hermesGroupString: String = DEFAULT_INTERNAL_HERMES_PUBLISHING_GROUP, | ||
| ) | ||
| ) { | ||
| val isNightly: Boolean = versionString.isNightly() |
Contributor
There was a problem hiding this comment.
Suggested change
| val isNightly: Boolean = versionString.isNightly() | |
| val isNightly: Boolean get() = versionString.isNightly() |
Contributor
|
a couple of nits to fix and then we can merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Even though Sonatype Central repository isn't used by an app, still the React Native Gradle plugin adds the Sonatype Central to repositories.
In some cases it leads to a considerable amount of failed requests on Gradle downloading dependencies.
I'm introducing a change where Sonatype Central repository is included for users of nightly builds only.
Changelog:
[ANDROID] [CHANGED] - Add Sonatype Central repository for users of nightly builds only
Test Plan:
All of the tests in gradle plugin are green