[Nexthop][fboss2-dev] Add fboss2 config applied-info.
#754
+253
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part02
branch
from
1bb9978 to
6a4eaf1
Compare
joseph5wu
requested changes
Dec 23, 2025
Contributor
joseph5wu
left a comment
joseph5wu
left a comment
There was a problem hiding this comment.
The fetching agent config applied info logic looks good to me.
But please address my concern about leaking the config cli support to regular fboss2 instead of keeping it only used by fboss2-dev.
cmake/CliFboss2.cmake
Outdated
Comment on lines
375
to
378
| fboss/cli/fboss2/commands/config/CmdConfigAppliedInfo.h | ||
| fboss/cli/fboss2/commands/config/CmdConfigAppliedInfo.cpp | ||
| fboss/cli/fboss2/commands/config/CmdConfigReload.h | ||
| fboss/cli/fboss2/commands/config/CmdConfigReload.cpp |
Contributor
There was a problem hiding this comment.
Make sure these files should only be used for fboss2-dev binary instead of fboss2
fboss/cli/fboss2/BUCK
Outdated
| "commands/clear/interface/prbs/CmdClearInterfacePrbs.h", | ||
| "commands/clear/interface/prbs/stats/CmdClearInterfacePrbsStats.h", | ||
| "commands/config/CmdConfigAppliedInfo.h", | ||
| "commands/config/CmdConfigAppliedInfo.cpp", |
Contributor
There was a problem hiding this comment.
This is a headers list, please move the .cpp into the src list.
Besides, please make sure all the config cli should only be used by fboss2-dev target; not fboss2
Contributor
|
Also please address the pre-commit clang format |
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part02
branch
from
6a4eaf1 to
3fcfa62
Compare
This was referenced Dec 23, 2025
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part02
branch
from
3fcfa62 to
cd67e0d
Compare
Contributor
Author
Done. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Dec 24, 2025
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` This command just calls `reloadConfig()` on the wedge_agent. Note: this change is part of a series, the next one is #754. Pull Request resolved: #753 Test Plan: Unit tests. Reviewed By: kevin645 Differential Revision: D89698241 Pulled By: joseph5wu fbshipit-source-id: 37c6cbe9ef175d91825a9d7b697422d25997d2e7
Sample output: ``` Config Applied Information: =========================== Last Applied Time: 2025-10-11 09:29:36.589 Last Coldboot Applied Time: 2025-10-11 06:44:36.741 ```
benoit-nexthop
force-pushed
the
fboss2-cli-prototype_part02
branch
from
cd67e0d to
92b1800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Sample output:
Note: this change is part of a series, the previous one is #753, the next one is #755.
Test Plan
Unit tests.