[chefctl] Move default lockfile location#103
Open
jaymzh wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
`/var/lock/subsys` was meant for SysV startup serialization, and was never the right locationf or our lockfile. Moreover, recent systemd releases no longer keep the `legacy.conf` configuration that creates `/var/lock/subsys`, so this means chefctl no longer works out of the box. Move the default to something more modern and sane. *NOTE*: If Meta doesn't explicitly set a `lock_file` setting in their `chefctl-config.rb`, they should before merging this. Signed-off-by: Phil Dibowitz <phil@ipom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/var/lock/subsyswas meant for SysV startup serialization, and wasnever the right locationf or our lockfile.
Moreover, recent systemd releases no longer keep the
legacy.confconfiguration that creates
/var/lock/subsys, so this means chefctlno longer works out of the box.
Move the default to something more modern and sane.
NOTE: If Meta doesn't explicitly set a
lock_filesetting in theirchefctl-config.rb, they should before merging this.Signed-off-by: Phil Dibowitz phil@ipom.com