Enable Pyrefly for fbcode/ax (#5236)#5236
Closed
maggiemoss wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082535. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5236 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 619 619
Lines 70273 70273
=======================================
Hits 67861 67861
Misses 2412 2412 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
connernilsen
approved these changes
Jun 22, 2026
connernilsen
left a comment
connernilsen
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
maggiemoss
added a commit
to maggiemoss/Ax
that referenced
this pull request
Jun 22, 2026
Summary: Pull Request resolved: facebook#5236 Migrates `fbcode/ax` from Pyre to Pyrefly by removing the root `python.set_pyrefly(False)` opt-out so the tree inherits `set_pyrefly(True)` from the fbcode root default. Pre-existing type errors are suppressed via annotation-only `# pyrefly: ignore` comments; no runtime changes. ___ Reviewed By: connernilsen Differential Revision: D109082535
maggiemoss
force-pushed
the
export-D109082535
branch
from
fd2f702 to
0e62ad5
Compare
meta-codesync
Bot
changed the title
Summary: Pull Request resolved: facebook#5236 Migrates `fbcode/ax` from Pyre to Pyrefly by removing the root `python.set_pyrefly(False)` opt-out so the tree inherits `set_pyrefly(True)` from the fbcode root default. Pre-existing type errors are suppressed via annotation-only `# pyrefly: ignore` comments; no runtime changes. ___ Reviewed By: connernilsen, saitcakmak Differential Revision: D109082535
maggiemoss
force-pushed
the
export-D109082535
branch
from
0e62ad5 to
ed0639f
Compare
|
This pull request has been merged in 025d7e5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates
fbcode/axfrom Pyre to Pyrefly by removing the rootpython.set_pyrefly(False)opt-out so the tree inheritsset_pyrefly(True)from the fbcode root default. Pre-existing type errors are suppressed via annotation-only# pyrefly: ignorecomments; no runtime changes.Reviewed By: connernilsen, saitcakmak
Differential Revision: D109082535