[enhancement] Compute minting setup parameters in parallel#191
Open
steveluscher wants to merge 1 commit intoexiled-apes:mainfrom
Open
[enhancement] Compute minting setup parameters in parallel#191steveluscher wants to merge 1 commit intoexiled-apes:mainfrom
steveluscher wants to merge 1 commit intoexiled-apes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the user clicks the mint button, we do four small async operations to set up the transaction. Despite the fact that none of these transactions depend on one another, we've written them to be executed in series.
Instead, what we can do is to generate all of the promises at once, let the network IO start, and wait on the results as a group.
This isn't going to result in a huge speedup, since most of the async work here is CPU bound and not network bound, but it's a good habit to get into none the less.
Type of change
How Has This Been Tested?
I loaded up the site locally and minted several tokens on devnet.