Add CustomAdapter for evaluation tools#22
Open
andrewtran117 wants to merge 2 commits intoevaleval:mainfrom
Open
Add CustomAdapter for evaluation tools#22andrewtran117 wants to merge 2 commits intoevaleval:mainfrom
andrewtran117 wants to merge 2 commits intoevaleval:mainfrom
Conversation
borgr
reviewed
Sep 5, 2025
borgr
left a comment
There was a problem hiding this comment.
Overall it looks good, I mainly wonder about higher level stuff here (naming and usecases).
So currently this works specifically from jsons, maybe the naming should convey it?
It is not custom in the sense that you expect someone to change the code to read their files. Someone still needs to change the outputs to the jsons, when will people use it?
I am thinking for example now on the EvEvEv people, will they want to use this code somehow? (They parse leaderboards into our format). We need to add to README and documentation to lead people to use it when they have a relevant usecase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CustomAdapter for onboarding user defined custom evaluation tools. Provides defaults for required schema fields and supports JSON/JSONL/directory inputs.