feat: aggregate statistics [ENG-2780, ENG-3139] by speaker-ender · Pull Request #7751 · ethyca/fides

speaker-ender · 2026-03-25T11:55:14Z

Ticket [ENG-2780, ENG-3139]

Description Of Changes

Adding a progress indicator widget to the action center

Code Changes

Updating the donut chard component to handle different types of dynamic sizing within containers

Steps to Confirm

Go to the action center and confirm that the new widgets display correct empty states that link to the integrations page when no monitors exist
Confirm that the correct visuals appear when monitors are added
Visit individual monitor screens (datastore, web monitor, integrations) and confirm that only data relevant to that monitor are displayed
Verify that the widgets do not display when the alpha flag is turned off

Pre-Merge Checklist

vercel · 2026-03-25T11:55:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Mar 27, 2026 4:27pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Mar 27, 2026 4:27pm

speaker-ender · 2026-03-26T14:57:03Z

clients/admin-ui/src/features/common/utils.ts

@@ -310,6 +296,20 @@ export const snakeCaseToTitleCase = (
    )
    .join(" ");

+/**
+ * Formats a number with a suffix for large numbers (K, M, etc.)
+ * @param num - The number to format
+ * @param digits - The number of digits to round to (default is 0)
+ * @returns The formatted number as a string
+ *
+ * See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat
+ *
+ * @example
+ * nFormatter(1111); // returns "1K"
+ * nFormatter(1111, 0); // returns "1K"
+ * nFormatter(1111, 1); // returns "1.1K"
+ * nFormatter(1111, 2); // returns "1.11K"
+ */


drive-by fixing of comments

claude

Code Review — feat: aggregate statistics [ENG-2780, ENG-3139]

Overall this is a well-structured feature: clean component decomposition, proper feature-flag gating, and the DonutChart enhancements (thin variant, fit prop) are nicely done. A few things to fix before merge:

Suggestions (fix before merge)

Typo in endpoint/hook names (getAggretateStatistics → getAggregateStatistics): propagates to both exported hooks and all call sites — worth fixing now before the name spreads further.
monitor_type optional but used in URL path: the query arg is typed monitor_type? but interpolated directly into the URL. Either make it required or add a guard.
Duplicated getMonitorUpdateName: identical function exists in both MonitorResultDescription.tsx and ProgressCard/utils.ts. Extract to a shared location.
Typo in user-facing string: "accross" → "across" in MONITOR_TYPE_TO_EMPTY_TEXT.
Typo in constant name: MONITOR_TYPE_TO_PERECENT_STATISTIC_LABEL → MONITOR_TYPE_TO_PERCENT_STATISTIC_LABEL.

Nice to Have

content-center vs items-center in DonutChart.tsx: content-center only affects multi-line flex containers; items-center is likely what was intended.
PropsWithChildren without children: ProgressCard never renders children, so the PropsWithChildren wrapper is unnecessary.
renderIcon defined inside component: pure function, no closure needed — move it outside MonitorStats.
Overly complex classNames spread pattern: classNames(...["a", ...(cond ? ["b"] : [])]) can be simplified to classNames("a", cond && "b") throughout.
heliosInsights test flag is true: most alpha flags use test: false. Confirm existing tests that render ActionCenterLayout or the website monitor page have been updated to account for the new stats widgets.
ExtendedDatastoreMonitorUpdates.ts appears unused: not imported anywhere in the PR — remove if not needed yet.

clients/admin-ui/src/features/data-discovery-and-detection/action-center/action-center.slice.ts

clients/admin-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/utils.ts

clients/fidesui/src/components/charts/DonutChart.tsx

clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorStats.tsx

clients/admin-ui/src/flags.json

clients/admin-ui/src/types/api/models/ExtendedDatastoreMonitorUpdates.ts

greptile-apps · 2026-03-26T16:03:12Z

Greptile Summary

This PR adds aggregate statistics widgets to the action center, introducing a new MonitorStats component and ProgressCard sub-components that display per-monitor-type progress (approval rate, status counts, top classifications) using a donut chart. The DonutChart component is also extended with a thin variant and a fit prop to support dynamic sizing within compact containers. All new widgets are gated behind the heliosInsights feature flag.

Key issues found:

Consistent typo in hook/endpoint name: getAggretateStatistics (and the exported hooks useGetAggretateStatisticsQuery / useLazyGetAggretateStatisticsQuery) are missing a "g" — should be getAggregateStatistics. This affects action-center.slice.ts and MonitorStats.tsx.
Typo in constant name: MONITOR_TYPE_TO_PERECENT_STATISTIC_LABEL in ProgressCard/utils.ts — PERECENT should be PERCENT.
Typo in user-facing text: "accross" should be "across" in the website empty-state description.
Single-character variable names: The destructured parameter k in ([k]) => key === k violates the project's full-name convention. This appears in both ProgressCard/utils.ts (line 12) and MonitorResultDescription.tsx (line 16).
Hardcoded string union for monitor_type: action-center.slice.ts defines monitor_type as "website" | "datastore" | "infrastructure" rather than using the newly added APIMonitorType enum. MonitorStats.tsx also uses string literals directly instead of enum values.
Duplicate helper function: getMonitorUpdateName is defined identically in both ProgressCard/utils.ts and MonitorResultDescription.tsx — it should be extracted and shared.
div used for text display: <div className="text-xs">None</div> in ProgressCard.tsx should use the fidesui Text component.
PR size: This PR touches 27 files, which exceeds the 15-file guideline.

Confidence Score: 4/5

Safe to merge once the hook/endpoint typo and the minor style issues are addressed; the feature is fully gated behind a flag.

All issues are cosmetic (typos, naming conventions, one duplicate helper) with no functional impact — the typo in the hook name is consistent across all usage sites so nothing is broken at runtime. The feature flag means no production exposure until explicitly enabled. A quick round of fixes brings this to merge-ready.

ProgressCard/utils.ts (three separate typos + short variable name + duplicate function) and action-center.slice.ts (endpoint name typo, raw string union instead of enum).

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorStats.tsx	New component that renders per-monitor-type statistics cards. Has a typo in the imported hook name (`useGetAggretateStatisticsQuery`) and uses hardcoded string literals instead of the `APIMonitorType` enum for `monitor_type` values.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/utils.ts	New utility file mapping monitor types to display labels and transforming API responses to card props. Contains two typos (`accross`, `PERECENT`), a single-char variable name (`k`), and duplicates `getMonitorUpdateName` from `MonitorResultDescription.tsx`.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/ProgressCard.tsx	New 277-line card component displaying a donut chart with numeric/percentage stats in both compact and full layouts. One bare `div` wrapping a "None" text string should use the fidesui `Text` component instead.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/action-center.slice.ts	Adds `getAggretateStatistics` RTK Query endpoint (typo — should be `getAggregateStatistics`) and a new `child_staged_resource_urns` array query param. The `monitor_type` param uses a raw string union rather than the `APIMonitorType` enum.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/constants.ts	Refactors `MONITOR_UPDATE_NAMES` Map to a plain `MONITOR_UPDATE_LABELS` object and extends it with `StatusCounts` keys. Clean change.
clients/fidesui/src/components/charts/DonutChart.tsx	Adds `thin` variant and a `fit` prop (`contain`/`fill`) to control how the chart scales within its container. Clean, well-scoped change.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResultDescription.tsx	Migrates from `MONITOR_UPDATE_NAMES` Map to `MONITOR_UPDATE_LABELS` object lookup. Introduces a single-char variable name (`k`) and duplicates the `getMonitorUpdateName` helper now also present in `ProgressCard/utils.ts`.

_{Reviews (1): Last reviewed commit: "refactor: flag naming" | Re-trigger Greptile}

clients/admin-ui/src/features/data-discovery-and-detection/action-center/action-center.slice.ts

clients/admin-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/utils.ts

...min-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/ProgressCard.tsx

clients/admin-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/utils.ts

kruulik · 2026-03-27T15:24:44Z

clients/fidesui/src/components/charts/DonutChart.tsx

  const { width, height } = useContainerSize(containerRef);
-  const size = Math.min(width, height);
+  const size =
+    fit === "contain" ? Math.min(width, height) : Math.max(width, height);


Great addition!

kruulik · 2026-03-27T15:26:00Z

clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorStats.tsx

+      <div
+        className={classNames(
+          "w-full",
+          !monitorId && "grid grid-cols-3 gap-4 pb-4",
+        )}
+      >


Would it be worth using Ant Col/Row for this?

Hmmm I'll give it a look.
Ant Col/Row is disappointing imo since it uses flex + requires lots of component boilerplate.
Performance aside, css grids are way more powerful and predictable for layouts.

kruulik · 2026-03-27T15:47:43Z

...min-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/ProgressCard.tsx

+        className={classNames(
+          `grid overflow-hidden w-full gap-2 xl:gap-4`,
+          compact
+            ? "grid-cols-[1fr,min-content,1fr,min-content,1fr]"
+            : "grid-cols-1 xl:grid-cols-[auto,1fr,1fr]",


Same comment as before - should we use Row/Col for this? Your approach is neater, just wanted to call out as an option.

kruulik · 2026-03-27T15:49:28Z

...min-ui/src/features/data-discovery-and-detection/action-center/ProgressCard/ProgressCard.tsx

+  switch (true) {
+    case percent > 80:
+      return "colorSuccess";
+    case percent > 60:
+      return "colorWarning";
+    default:
+      return "colorErrorTextHover";


Future consideration: I think we should standardize thresholds for colors.

Absolutely.
We should have rules that also apply outside of numeric thresholds as well.
This was just an initial pass for now.

kruulik

Approving - my comments are minor and don't need to be addressed in this PR, just future considerations.

chore: more types chore: even more types chore: all the types wip: something that works chore: adding query hook chore: wip chore: more types chore: more type updates wip: more card stuff chore: update types wip: some labels and such chore: fix comments core: layout improvements and refactoring chore: linting and formatting chore: more responsiveness chore: further refactors wip: stuf chore: comment out refactor: compact variant chore: mostly there fix: formatting fix: donut chart fit feature fix: formatting chore: adding changelog

chore: update text fix: linting and formatting

vercel bot had a problem deploying to Preview – fides-plus-nightly March 25, 2026 11:56 Failure

speaker-ender force-pushed the feat/aggregate-statistics--ENG-2780 branch from 884b3fc to fea1609 Compare March 25, 2026 12:24

vercel bot deployed to Preview – fides-plus-nightly March 25, 2026 12:29 View deployment

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 14:38 View deployment

speaker-ender commented Mar 26, 2026

View reviewed changes

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 14:57 View deployment

speaker-ender force-pushed the feat/aggregate-statistics--ENG-2780 branch from c07ee8e to 92bb486 Compare March 26, 2026 14:59

vercel bot had a problem deploying to Preview – fides-plus-nightly March 26, 2026 15:02 Failure

speaker-ender changed the title ~~feat: aggregate statistics [ENG-2780]~~ feat: aggregate statistics [ENG-2780, ENG-3139] Mar 26, 2026

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 15:15 View deployment

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 15:30 View deployment

speaker-ender marked this pull request as ready for review March 26, 2026 15:56

speaker-ender requested a review from a team as a code owner March 26, 2026 15:56

speaker-ender requested review from kruulik and removed request for a team March 26, 2026 15:56

speaker-ender force-pushed the feat/aggregate-statistics--ENG-2780 branch from 64de1e1 to 86dd160 Compare March 26, 2026 15:56

claude bot reviewed Mar 26, 2026

View reviewed changes

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 16:02 View deployment

greptile-apps bot reviewed Mar 26, 2026

View reviewed changes

vercel bot deployed to Preview – fides-plus-nightly March 26, 2026 16:27 View deployment

kruulik reviewed Mar 27, 2026

View reviewed changes

kruulik approved these changes Mar 27, 2026

View reviewed changes

speaker-ender added 3 commits March 27, 2026 12:02

feat: empty states and website monitor progress

07da01f

chore: update text fix: linting and formatting

feat: putting behind flag

4512791

speaker-ender added 5 commits March 27, 2026 12:02

fix: incorrect icon

eac0b2c

refactor: flag naming

5f55e0a

fix: suggestions

793c577

fix: tailwind class

45e9d28

refactor: increasing donut gap for compact progress card

31ad093

speaker-ender force-pushed the feat/aggregate-statistics--ENG-2780 branch from 396d22b to 31ad093 Compare March 27, 2026 16:21

speaker-ender enabled auto-merge March 27, 2026 16:22

vercel bot deployed to Preview – fides-plus-nightly March 27, 2026 16:27 View deployment

speaker-ender added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit f034bd8 Mar 27, 2026
47 of 50 checks passed

speaker-ender deleted the feat/aggregate-statistics--ENG-2780 branch March 27, 2026 16:42

speaker-ender added a commit that referenced this pull request Mar 27, 2026

feat: aggregate statistics [ENG-2780, ENG-3139] (#7751)

817368a

Conversation

speaker-ender commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

speaker-ender Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Code Review — feat: aggregate statistics [ENG-2780, ENG-3139]

Suggestions (fix before merge)

Nice to Have

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Mar 26, 2026

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kruulik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kruulik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kruulik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kruulik Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

speaker-ender Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kruulik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

speaker-ender commented Mar 25, 2026 •

edited

Loading

vercel bot commented Mar 25, 2026 •

edited

Loading