Allow zero safeBlockHash and finalizedBlockHash after finalization#760
Open
dapplion wants to merge 1 commit intoethereum:mainfrom
Open
Allow zero safeBlockHash and finalizedBlockHash after finalization#760dapplion wants to merge 1 commit intoethereum:mainfrom
dapplion wants to merge 1 commit intoethereum:mainfrom
Conversation
c943ecb to
7736063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeBlockHashandfinalizedBlockHashmust be non-zero once the transition block is finalized-38002invalid forkchoice state check now only applies to non-zero hashesMotivation
During extended non-finality periods, a CL client checkpoint-syncing from a non-finalized state may not yet know the network's finalized or safe block hash. The current spec forces the CL to provide non-zero values post-merge, which is not always possible. This change lets the CL signal "unknown" by sending zeroes, with the EL falling back to its last known state.
The other options are:
See also: sigp/lighthouse#8382