a11y: flatten interactive nesting (restore localized aria-label)#113
Merged
JohnMcLear merged 1 commit intomasterfrom May 10, 2026
Merged
a11y: flatten interactive nesting (restore localized aria-label)#113JohnMcLear merged 1 commit intomasterfrom
JohnMcLear merged 1 commit intomasterfrom
Conversation
Flattens nested <a>/<button>/<span> wrappers to a single <a> carrying the icon classes plus role="button"/tabindex="0". With no element children (or with data-l10n-id ending in a recognized attribute suffix), etherpad's html10n auto-populates aria-label from the localized translation per html10n.ts:665-678. Restores screen-reader accessibility lost in the Phase 3a aria-label sweep, where elements with element children plus a non-suffix data-l10n-id ended up with no accessible name.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flattens nested toolbar markup to a single
<a role="button" tabindex="0">carrying the icon classes. With no element children (or with a recognized attribute suffix indata-l10n-id), etherpad's html10n auto-populatesaria-labelfrom the localized string perhtml10n.ts:665-678.Why this PR exists: the earlier Phase 3a sweep removed hardcoded
aria-label="…"on toolbar buttons that have element children (<span>/<button>) and adata-l10n-idwithout a recognized attribute suffix (.title/.alt/.value/.placeholder). For those elements, html10n skips its auto-population path, so they ended up with no accessible name. Flattening the structure makes the auto-population fire.