refactor: serve hide CSS from eejsBlock_styles via hideCSS helper#89
Merged
Conversation
Previously this plugin injected the gritter-error CSS client-side from postAceInit, which means error notifications could briefly flash on screen between page load and editor init. Switching to server-side eejsBlock_styles via the hideCSS helper from ep_plugin_helpers makes the CSS available with the initial HTML response, so errors are hidden from the very first paint. Behavioral changes: - Drops the static/js/disable_error_messages.js client file in favor of a server index.js. - Updates ep.json to reflect the hook move (client_hooks.postAceInit → hooks.eejsBlock_styles). - Same selector (#gritter-container > .error), same display: none rule.
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the hide-error-gritter CSS from a client-side
postAceInithook (which appends a<style>to<body>after editor init) to a server-sideeejsBlock_styleshook viahideCSS()fromep_plugin_helpers.Behavioral improvement: the CSS is now in the initial HTML response, so error notifications are hidden from the very first paint. The previous approach left a brief window between page load and
postAceInitwhere errors could flash on screen.Selector and display rule are unchanged.
Wave 4 of the Phase 4 sweep.