Skip to content

Conversation

@SwetaTanwar
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Enable linting CSS files, handy for test.css file for triaging issues & working on rules.

What changes did you make? (Give an overview)

Update ESLint config to lint CS files, it seems it was removed in #324

Related Issues

NA

Is there anything you'd like reviewers to focus on?

No

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 21, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Dec 25, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 25, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch! I've left one comment on it.


Indeed, there was a configuration for css prior to #324.

Image

Also, I used this feature when I worked on the CSS repository, and there's a test.css entry in .gitignore to verify it:

css/.gitignore

Line 62 in 17746f9

test.css

Comment on lines +108 to +114
{
name: "css/css",
files: ["**/*.css"],
language: "css/css",
plugins: { css },
extends: ["css/recommended"],
},
Copy link
Member

@lumirlumir lumirlumir Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
name: "css/css",
files: ["**/*.css"],
language: "css/css",
plugins: { css },
extends: ["css/recommended"],
},
// This CSS configuration is mainly used to validate the `test.css` file for local testing.
{
name: "css/css",
plugins: { css },
files: ["**/*.css"],
language: "css/css",
extends: ["css/recommended"],
},

Can we add a comment like above to ensure not to be removed in the future by mistake?

Also, as a non-blocking request, I think it would be nice if the property keys were ordered name -> plugins, like in the JSON configuration.

@lumirlumir lumirlumir moved this from Triaging to Implementing in Triage Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

3 participants