fix: auto re-authenticate when stored GitHub token returns 401#202
Open
xuangong wants to merge 1 commit intoericc-ch:masterfrom
Open
fix: auto re-authenticate when stored GitHub token returns 401#202xuangong wants to merge 1 commit intoericc-ch:masterfrom
xuangong wants to merge 1 commit intoericc-ch:masterfrom
Conversation
When the stored GitHub token becomes invalid (expired or revoked), the API call to verify the user returns 401 Bad Credentials. Previously this caused the server to crash with an unhandled error. Now the invalid token is automatically cleared and the device code authentication flow is triggered, so the user can re-authenticate without manually deleting the token file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the stored GitHub token becomes invalid (expired or revoked), calling
getGitHubUser()during startup returns 401 Bad Credentials. The error propagates up and crashes the server, requiring the user to manually delete the token file and restart.Solution
Catch the 401 error from
logUser()insetupGitHubToken(), automatically clear the invalid token (both from state and the token file), and fall through to the device code authentication flow so the user can re-authenticate seamlessly.Changes
src/lib/token.ts: WraplogUser()in a try-catch; on 401, clear the stored token and proceed to re-auth instead of crashing.